From owner-svn-ports-all@FreeBSD.ORG  Wed Sep  3 15:29:40 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EB8123BA;
 Wed,  3 Sep 2014 15:29:40 +0000 (UTC)
Received: from mail-yh0-x230.google.com (mail-yh0-x230.google.com
 [IPv6:2607:f8b0:4002:c01::230])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 806601A14;
 Wed,  3 Sep 2014 15:29:40 +0000 (UTC)
Received: by mail-yh0-f48.google.com with SMTP id b6so5360952yha.21
 for <multiple recipients>; Wed, 03 Sep 2014 08:29:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=C8PY5aYef4KyomFmL5+d4uZ+qQItaTE6m/CQ/UziqOI=;
 b=pwYtmKsWMAxmNMgzZy/h9Dd18J1a0xbZVdKyCmgAX4EjaUx0bzKG3BFUDosTMlvUed
 L9/DQpjxrkwEotaymUd7p8Feq/7QLsHLfpV3rnPJid2C+pYoWARjtJEWjoMnPgRh16hl
 q5x/7DbWTbbt8z0Rl4c1jta+c6SCXYzzaYHcUt4KH1fBBxCN1bTR/3jFEmO8GO97MeJM
 /+FrD5+XW0KxlLqKjYO3+hsae/VLpwgzqPcGQZISmqa1NfP+BoWeBazY93/dz7cMOLiF
 BjxAGnGiMDlxCBrVVRybTLtyGf6LtdUo5/RnTBHM5XP/WZRwOAAfqndAJML6ffkXIiRQ
 S7AQ==
MIME-Version: 1.0
X-Received: by 10.236.25.105 with SMTP id y69mr62081408yhy.33.1409758179643;
 Wed, 03 Sep 2014 08:29:39 -0700 (PDT)
Sender: antoine.brodin.freebsd@gmail.com
Received: by 10.170.164.197 with HTTP; Wed, 3 Sep 2014 08:29:39 -0700 (PDT)
In-Reply-To: <20140903152826.GA38672@FreeBSD.org>
References: <201409031525.s83FPHLO090538@svn.freebsd.org>
 <20140903152826.GA38672@FreeBSD.org>
Date: Wed, 3 Sep 2014 17:29:39 +0200
X-Google-Sender-Auth: V-BKRqe2VGdjMYb6xGwQAnPuoXQ
Message-ID: <CAALwa8mFDk89uAZOqic_RzeWD5c=Uh_sR+N8dREg-nCx=z5ofA@mail.gmail.com>
Subject: Re: svn commit: r367212 - in head: astro/planets devel/aifad
 ftp/ocaml-ocurl
From: Antoine Brodin <antoine@freebsd.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Sep 2014 15:29:41 -0000

On Wed, Sep 3, 2014 at 5:28 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Wed, Sep 03, 2014 at 03:25:17PM +0000, Antoine Brodin wrote:
>> New Revision: 367212
>> URL: http://svnweb.freebsd.org/changeset/ports/367212
>>
>> Log:
>>   Fix packaging
>> [...]
>>
>> -PORTDOCS=    KEYBINDINGS.txt getting_started.html
>> -PLIST_FILES= bin/planets man/man1/planets.1.gz
>> -
>>  do-install:
>>       ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin
>>       ${INSTALL_MAN} ${WRKSRC}/planets.1 ${STAGEDIR}${MANPREFIX}/man/man1
>>       @${MKDIR} ${STAGEDIR}${DOCSDIR}
>> -.for doc in ${PORTDOCS}
>> -     ${INSTALL_DATA} ${WRKSRC}/${doc} ${STAGEDIR}${DOCSDIR}
>> -.endfor
>> +     ${INSTALL_DATA} ${WRKSRC}/KEYBINDINGS.txt ${STAGEDIR}${DOCSDIR}
>> +     ${INSTALL_DATA} ${WRKSRC}/getting_started.html ${STAGEDIR}${DOCSDIR}
>>
>> [...]
>> +bin/planets
>> +man/man1/planets.1.gz
>> +%%PORTDOCS%%%%DOCSDIR%%/KEYBINDINGS.txt
>> +%%PORTDOCS%%%%DOCSDIR%%/getting_started.html
>> +%%PORTDOCS%%@dirrm %%DOCSDIR%%
>
> Hey Antoine, can you explain what's going on here?  Lots of ports are using
> PLIST_FILES/PORTDOCS to avoid spamming the tree with little pkg-plist files,
> and now you're essentially reverting it back.


It fails to package because bsd.ocaml.mk is stupid, i just fix.

Cheers,

Antoine