Date: Thu, 6 Feb 2014 00:02:52 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: Tijl Coosemans <tijl@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r342718 - head/audio/libmad Message-ID: <CAMHz58T7pAfaWp9Vzt1N6kZd3DLgnu1q7fFBUwx0YmqLM4BGkQ@mail.gmail.com> In-Reply-To: <20140205165319.06494484@kalimero.tijl.coosemans.org> References: <201402051529.s15FTbbV098516@svn.freebsd.org> <0807AAFF65F7176953AA8581@ogg.in.absolight.net> <3A1E876406193F10101E533D@ogg.in.absolight.net> <20140205165319.06494484@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 5, 2014 at 11:53 PM, Tijl Coosemans <tijl@freebsd.org> wrote: > On Wed, 05 Feb 2014 16:38:41 +0100 Mathieu Arnold wrote: > > +--On 5 f=C3=A9vrier 2014 16:35:22 +0100 Mathieu Arnold <mat@FreeBSD.or= g> > wrote: > >| +--On 5 f=C3=A9vrier 2014 15:29:37 +0000 Sunpoet Po-Chuan Hsieh > >| <sunpoet@FreeBSD.org> wrote: > >|| Author: sunpoet > >|| Date: Wed Feb 5 15:29:37 2014 > >|| New Revision: 342718 > >|| URL: http://svnweb.freebsd.org/changeset/ports/342718 > >|| QAT: https://qat.redports.org/buildarchive/r342718/ > >|| > >|| Log: > >|| - Use USES=3Dlibtool > >|| > >|| Modified: > >|| head/audio/libmad/Makefile > >|| > >|| Modified: head/audio/libmad/Makefile > >|| > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >|| =3D=3D=3D=3D=3D --- head/audio/libmad/Makefile Wed Feb 5 15:2= 9:04 2014 > (r342717) > >|| +++ head/audio/libmad/Makefile Wed Feb 5 15:29:37 2014 > (r342718) @@ > >|| -15,8 +15,8 @@ SPEED_DESC=3D Optimize for speed over accu > >|| > >|| CONFIGURE_ARGS=3D --disable-debugging --enable-sso > >|| GNU_CONFIGURE=3D yes > >|| -USE_AUTOTOOLS=3D libtool > >|| USE_LDCONFIG=3D yes > >|| +USES=3D libtool > >|| > >|| SUB_LIST=3D VERSION=3D${PORTVERSION} > >|| SUB_FILES=3D mad.pc > >|| > >| > >| I'm quite sure you forgot to update the plist. > > > > And quite possibly bump PORTREVISION in the ports that depend on it. > > USES=3Dlibtool also decrements the library version in this case which > should be avoided, so you have to patch the port to decrement age until > the library version is the same as before. I've attached a patch which > does this. > I misread libtool.mk. :( I meant to use USES=3Dlibtool:oldver to avoid shared library changes (at least for now). I've fixed it. Thanks. Regards, sunpoet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58T7pAfaWp9Vzt1N6kZd3DLgnu1q7fFBUwx0YmqLM4BGkQ>