From owner-freebsd-current@FreeBSD.ORG Fri Jul 18 00:58:22 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A3731065672 for ; Fri, 18 Jul 2008 00:58:22 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.228]) by mx1.freebsd.org (Postfix) with ESMTP id 0E5188FC1C for ; Fri, 18 Jul 2008 00:58:22 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so188171rvf.43 for ; Thu, 17 Jul 2008 17:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from :to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=+wzORL2sHvD390Tbn6ulebBJgt0h6cjQzGVobMHhb0Y=; b=UwXAwxyB9E25Bj+rWly2lfgWlgktKvcdM58kC4EeqQloSELhEU2mnMcPWLNINQ+jJ4 5UBj6Me9kZB52qbpoLN2qARgn3oIYKYOHx3zNwM1Ye2c8RIcP/y4NpXZ3GNzYOlrW1jy +XYo/vIJ9FqrTuTP64cQ3nYoGLaPtvM9Xzl2U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=t0SrCGA3/s7O7JVZ2AJ+MLkuTrwqZzWLDcVBwr36eEgDxuWuTq1fmkBSxQmQL9S/FD hV3ja6XLMbj/wXhvS94GEwXHXMeVttQG3U8kMNnh3ZoAtnPbS8ae4RMV8ZF+xEMHOF+S 7vjPb6ci4+k15bJbnOuH3l/v72xuFftmXrnyY= Received: by 10.141.41.12 with SMTP id t12mr1494982rvj.282.1216341204184; Thu, 17 Jul 2008 17:33:24 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id f21sm321148rvb.0.2008.07.17.17.33.21 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 17 Jul 2008 17:33:23 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id m6I0VD96053051 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 18 Jul 2008 09:31:13 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id m6I0VDTZ053050; Fri, 18 Jul 2008 09:31:13 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Fri, 18 Jul 2008 09:31:13 +0900 From: Pyun YongHyeon To: Andrew Thompson Message-ID: <20080718003112.GA52865@cdnetworks.co.kr> References: <200805190140.m4J1e0YW001168@repoman.freebsd.org> <20080717235630.GL33414@citylink.fud.org.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080717235630.GL33414@citylink.fud.org.nz> User-Agent: Mutt/1.4.2.1i Cc: current@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/age if_age.c if_agereg.h if_agevar.h X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jul 2008 00:58:22 -0000 On Thu, Jul 17, 2008 at 04:56:30PM -0700, Andrew Thompson wrote: > On Mon, May 19, 2008 at 01:39:59AM +0000, Pyun YongHyeon wrote: > > yongari 2008-05-19 01:39:59 UTC > > > > FreeBSD src repository > > > > Added files: > > sys/dev/age if_age.c if_agereg.h if_agevar.h > > Log: > > Add age(4), a driver for Attansic/Atheros L1 gigabit ethernet > > controller. > > +static void > +age_phy_reset(struct age_softc *sc) > +{ > + > + /* Reset PHY. */ > + CSR_WRITE_4(sc, AGE_GPHY_CTRL, GPHY_CTRL_RST); > + pause("agephy", hz / 1000); > + CSR_WRITE_4(sc, AGE_GPHY_CTRL, GPHY_CTRL_CLR); > + pause("agephy", hz / 1000); > +} > > This will panic if hz < 1000, perhaps a DELAY(1) is better? Ah, yes. I'll fix that. Thanks a lot! > > > Andrew -- Regards, Pyun YongHyeon