From owner-freebsd-current  Mon Feb 11 18:47:50 2002
Delivered-To: freebsd-current@freebsd.org
Received: from newman2.bestweb.net (newman2.bestweb.net [209.94.102.67])
	by hub.freebsd.org (Postfix) with ESMTP id 06FE437B632
	for <freebsd-current@freebsd.org>; Mon, 11 Feb 2002 18:18:34 -0800 (PST)
Received: from okeeffe.bestweb.net (okeefe.bestweb.net [209.94.100.110])
	by newman2.bestweb.net (Postfix) with ESMTP
	id 5C5522310E; Mon, 11 Feb 2002 21:17:47 -0500 (EST)
Received: by okeeffe.bestweb.net (Postfix, from userid 0)
	id 4D61D9F363; Mon, 11 Feb 2002 21:12:29 -0500 (EST)
To: Munehiro Matsuda <haro@h4.dion.ne.jp>
Cc: Georg.Koltermann@mscsoftware.com, freebsd-current@freebsd.org, 
Subject: Re: /dev/rtc not configured message when starting VMWare2 on -current
Cc: Takanori Saneto <sanewo@ba2.so-net.ne.jp>
From: Takanori Saneto <sanewo@ba2.so-net.ne.jp>
Date: Sun, 10 Feb 2002 03:01:57 +0900
Message-Id: <20020212021229.4D61D9F363@okeeffe.bestweb.net>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Re: "Re: /dev/rtc not configured message when starting VMWare2 on -current"
In article <20020209002638L.haro@h4.dion.ne.jp>,
	Munehiro Matsuda <haro@h4.dion.ne.jp> wrote:
>I have a hack^Wpatch that should fix your problem.

I think you need to prevent returning the value of uninitialized
variable (``error'') when no error should be returned.

How about following patch? (just added "error = 0;" line)

Index: rtc.c
===================================================================
RCS file: /export/cvsup/cvs/ports/emulators/rtc/files/rtc.c,v
retrieving revision 1.6
diff -u -r1.6 rtc.c
--- rtc.c	16 Sep 2001 07:05:18 -0000	1.6
+++ rtc.c	9 Feb 2002 17:54:44 -0000
@@ -266,10 +266,32 @@
 {
 int error;
 
+#if __FreeBSD_version >= 500023
+dev_t dev;
+struct rtc_softc *sc;
+
+	if (rtc_sc!=NULL)
+		return (EINVAL);
+
+  	dev = make_dev(&rtc_cdevsw, 0, UID_ROOT, GID_WHEEL, 0644, DEVICE_NAME); 
+	if (dev==NULL)
+		return (EINVAL);
+
+	MALLOC(sc, struct rtc_softc*, sizeof(*sc), M_DEVBUF, M_WAITOK);
+	if (sc==NULL)
+		return (EINVAL);
+
+	bzero(sc, sizeof(*sc));
+	rtc_sc = sc;
+	dev->si_drv1 = sc; /* Link together */
+	sc->dev = dev;
+	error = 0;
+#else
    	error = cdevsw_add(&rtc_cdevsw);
 	if (error) 
 		return error;
 
+#endif
 	return error;
 }
 

-- 
さねを (SANETO Takanori)             // [趣味] 本業をすること //
・・・・・・・・・・・・・・・・・ //    Bonjour Chapeau     //
<URL:mailto:sanewo@ba2.so-net.ne.jp> // [本業] 趣味に走ること //

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message