From owner-freebsd-ports Sun Jan 2 17:20: 5 2000 Delivered-To: freebsd-ports@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 943C714EDF for ; Sun, 2 Jan 2000 17:20:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id RAA78246; Sun, 2 Jan 2000 17:20:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Date: Sun, 2 Jan 2000 17:20:03 -0800 (PST) Message-Id: <200001030120.RAA78246@freefall.freebsd.org> To: freebsd-ports@FreeBSD.org Cc: From: dirk.meyer@dinoex.sub.org (Dirk Meyer) Subject: Re: ports/15842: news/cnews more robust patches Reply-To: dirk.meyer@dinoex.sub.org (Dirk Meyer) Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR ports/15842; it has been noted by GNATS. From: dirk.meyer@dinoex.sub.org (Dirk Meyer) To: FreeBSD-gnats-submit@FreeBSD.ORG, sprice@hiwaay.net (Steve Price) Cc: Subject: Re: ports/15842: news/cnews more robust patches Date: Sun, 02 Jan 2000 21:30:36 +0100 Steve Price wrote:, > On Sun, 2 Jan 2000 dirk.meyer@dinoex.sub.org wrote: > > # @@ -60,6 +60,9 @@ > # .include > # > # .if ${OSVERSION} < 300000 > # +.if make(makesum) | defined(FETCH_ALL) > ^ > This should be a '||', no? > > # +PATCHFILES+= c-news-patch-gawk3 > # +.endif > # .else > # PATCHFILES+= c-news-patch-gawk3 > # .endif It sould be an logical OR, I took it without much testing from ports/setiathome/Makefile: ---- snip --- .if make(makesum) | defined(FETCH_ALL) DISTFILES= setiathome-1.2.i386-unknown-freebsd2.2.6.tar \ setiathome-1.2.i386-unknown-freebsd2.2.7.tar \ setiathome-1.2.i386-unknown-freebsd2.2.8.tar \ setiathome-1.2.i386-unknown-freebsd3.1.tar \ setiathome-1.2.i386-unknown-freebsd3.2.tar \ setiathome-1.1.i386-unknown-freebsd4.0.tar .endif ---- snip --- as far as I tested it both seem to work. But the "||" is documented, and should be used. kind regards Dirk - Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany - Tel. +49-5606-6512 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message