From owner-freebsd-fs@FreeBSD.ORG Sat Jan 28 23:57:19 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFE63106566C for ; Sat, 28 Jan 2012 23:57:19 +0000 (UTC) (envelope-from uffe@uffe.org) Received: from mail.starion.dk (mx0.starion.dk [93.162.70.34]) by mx1.freebsd.org (Postfix) with SMTP id 0D8AD8FC12 for ; Sat, 28 Jan 2012 23:57:18 +0000 (UTC) Received: (qmail 79874 invoked by uid 1004); 28 Jan 2012 23:57:40 -0000 Message-ID: <4F248B44.1090304@uffe.org> Date: Sun, 29 Jan 2012 00:56:52 +0100 From: Uffe Jakobsen X-Mozilla-Draft-Info: internal/draft; vcard=0; receipt=0; DSN=0; uuencode=0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: freebsd-fs@freebsd.org References: <201201272310.q0RNABvZ065758@freefall.freebsd.org> <20120128004755.GA89980@icarus.home.lan> <4F246CA9.30803@uffe.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: kern/164516: [ext2fs] unable to mount EXT2 filesystem X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2012 23:57:19 -0000 On 2012-01-28 23:31, Chris Rees wrote: > > On 28 Jan 2012 22:14, "Uffe Jakobsen" > wrote: > > > > > > > > On 2012-01-28 01:47, Jeremy Chadwick wrote: > >> > >> On Fri, Jan 27, 2012 at 11:10:11PM +0000, Uffe Jakobsen wrote: > >>> > >>> The following reply was made to PR kern/164516; it has been noted > by GNATS. > >>> > >>> From: Uffe Jakobsen> > >>> To: bug-followup@FreeBSD.org > >>> Cc: > >>> Subject: Re: kern/164516: [ext2fs] unable to mount EXT2 filesystem > >>> Date: Fri, 27 Jan 2012 20:49:05 +0100 > >>> > >>> > > >>> > Not a bug. The file system type name is "ext2fs" not "ext2". > >>> > Use "mount -t ext2fs /dev/md0 /mnt/tmp0" instead. > >>> > > >>> > >>> Instead of reporting "Operation not supported by device" > >>> Shouldn't it report unknown filesystem type ? > >> > >> > >> Please look through /usr/include/errno.h and let us know what error code > >> would represent "unknown filesystem type". :-) > >> > > > > There are plenty of other places in the mount src where we exit > without a specific error code. Question is if there exists a scenario > where the requested filesystem type would/could not be found by > getvfsbyname() ? > > > > I've met this problem myself a number of times - and even in this > case I did not spot the spelling error right away ('ext2fs' and not 'ext2'). > > > > The returned error 'Operation not supported by device' - atleast to > me - indicates that the mount process got much further before running > into some kind of problem. The times when I've met this error I've begun > inspecting mount options etc before realizing that the fstype had a typo. > > > > Normally when an error comes up I check the manpage. Manpage for mount does not at all mention any error conditions. You'll have to know the inner workings of mount in order to know that in certain cases everything is thrown into nmount() and any error that comes up would come directly from nmount() Anyway - would you accept a patch that checked the fstype using getvfsbyname() before calling nmount() ? /Uffe