From owner-svn-ports-head@freebsd.org Sat Nov 17 08:41:35 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 43BEA112CBC9; Sat, 17 Nov 2018 08:41:35 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE8F7810C5; Sat, 17 Nov 2018 08:41:34 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 42xpVM6qBwzDj6N; Sat, 17 Nov 2018 08:41:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new, port 10587) with ESMTPS id KmKgZ-TKfeXx; Sat, 17 Nov 2018 08:41:31 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:201:9eda:3eff:fe70:24c0]) by mail.daemonic.se (Postfix) with ESMTPSA id 42xpVM2T3rzDhFd; Sat, 17 Nov 2018 08:41:31 +0000 (UTC) Subject: Re: svn commit: r484941 - head/graphics/drm-devel-kmod To: Tobias Kortkamp , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201811142012.wAEKCcn4021442@repo.freebsd.org> <1542237219.290523.1577323056.21E82AF1@webmail.messagingengine.com> From: Niclas Zeising Message-ID: <12e38147-8d10-63a2-8fa1-870c0490729d@freebsd.org> Date: Sat, 17 Nov 2018 09:41:22 +0100 User-Agent: Mutt/1.5.21 MIME-Version: 1.0 In-Reply-To: <1542237219.290523.1577323056.21E82AF1@webmail.messagingengine.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BE8F7810C5 X-Spamd-Result: default: False [-0.01 / 15.00]; ASN(0.00)[asn:36236, ipnet:176.58.89.0/24, country:US]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_SHORT(-0.01)[-0.012,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2018 08:41:35 -0000 On 11/15/18 12:13 AM, Tobias Kortkamp wrote: > On Wed, Nov 14, 2018, at 21:12, Niclas Zeising wrote: >> Author: zeising >> Date: Wed Nov 14 20:12:38 2018 >> New Revision: 484941 >> URL: https://svnweb.freebsd.org/changeset/ports/484941 >> >> Log: >> graphics/drm-devel-kmod: Fix runtime >> >> Fix runtime after stolen memory handling was comitted. Use FreeBSD 1200086 >> as delimiter, since FreeBSD versions wasn't bumped for the stolen memory >> commit. > > Was there supposed to be a OSVERSION bump in the commit? Does it > still work reliably with >= 1200067 or only with >= 1200086 ? > Hi! I think Johannes wanted a version bump when the stolen memory handling went in to FreeBSD base. The version number is used internally in the source, that's why there's no bump in the ports makefile. drm-devel-kmod might work on versions lower than 1200086, it mostly depends on how bios handles stolen memory, and on your GPU. I've had trouble with it, before this change, but I know others where it worked. In any case, to use the -devel kmod you are expected to track a somewhat recent current in most cases. Regards -- Niclas Zeising