From owner-svn-src-head@FreeBSD.ORG  Mon Jan  6 12:07:11 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C608FC96;
 Mon,  6 Jan 2014 12:07:11 +0000 (UTC)
Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com
 [IPv6:2a00:1450:400c:c05::235])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C0F2919A8;
 Mon,  6 Jan 2014 12:07:10 +0000 (UTC)
Received: by mail-wi0-f181.google.com with SMTP id hq4so2714884wib.2
 for <multiple recipients>; Mon, 06 Jan 2014 04:07:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=o0uPRLMuhiJRytL+v9xymbMsLV70sicncf6vBK5mqpk=;
 b=It7slNckNm7LnB+PmXxbtE8sCJl4joj/uJsUYHPN0lyjgQ9qaBj+BK0nhPAJQzPcTY
 f07Ta2noALYplxAjAobgRyMS0J70HmGCMK1Ed/Z5DUcS6N1XHO8L5wVP8kUDlBefi2Ia
 88EloGay1sJX7Cq8CcFpbZDqdOcEnTq2MA+wY6PvgVLaE9eNuIe2dY7O0j2gVwASnZS3
 IGMKv5PNESwyOrPzFOFu1p/x6AeKdQ9ZSX1aDtuR7TKc+C/v6zGt7sFcpRO1i6DyrMs7
 k9yNTdKWdD7KHigkjUeEDLzzCpeW5SR00/DpJtk4j6G/WmdXO1H8XgteCsoTqO4r+hrN
 v/sw==
MIME-Version: 1.0
X-Received: by 10.180.188.175 with SMTP id gb15mr12066891wic.50.1389010029261; 
 Mon, 06 Jan 2014 04:07:09 -0800 (PST)
Sender: zbodek@gmail.com
Received: by 10.217.112.65 with HTTP; Mon, 6 Jan 2014 04:07:09 -0800 (PST)
In-Reply-To: <52CA3C07.9030002@FreeBSD.org>
References: <201401012003.s01K3ngn009757@svn.freebsd.org>
 <1388976912.1158.331.camel@revolution.hippie.lan>
 <52CA3C07.9030002@FreeBSD.org>
Date: Mon, 6 Jan 2014 13:07:09 +0100
X-Google-Sender-Auth: kxh9t0dNog0Bpgjl9ZQop1BBuWI
Message-ID: <CALF_TxkhRo3MWRE2Mpsi_KjxGffJaTpOqs=1tbPTbWbUNKyK=g@mail.gmail.com>
Subject: Re: svn commit: r260161 - in head/sys/arm: arm include
From: Zbigniew Bodek <zbb@freebsd.org>
To: Andreas Tobler <andreast@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Ian Lepore <ian@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jan 2014 12:07:12 -0000

2014/1/6 Andreas Tobler <andreast@freebsd.org>:
> On 06.01.14 03:55, Ian Lepore wrote:
>> On Wed, 2014-01-01 at 20:03 +0000, Zbigniew Bodek wrote:
>>> Author: zbb
>>> Date: Wed Jan  1 20:03:48 2014
>>> New Revision: 260161
>>> URL: http://svnweb.freebsd.org/changeset/base/260161
>>>
>>> Log:
>>>   Add polarity and level support to ARM GIC
>>>
>>>   Add suport for setting triggering level and polarity in GIC.
>>>   New function pointer was added to nexus which corresponds
>>>   to the function which sets level/sense in the hardware (GIC).
>>>
>>>   Submitted by:      Wojciech Macek <wma@semihalf.com>
>>>   Obtained from:     Semihalf
>>>
>>> Modified:
>>>   head/sys/arm/arm/gic.c
>>>   head/sys/arm/arm/intr.c
>>>   head/sys/arm/arm/nexus.c
>>>   head/sys/arm/include/intr.h
>>>
>> [...]
>>> Modified: head/sys/arm/include/intr.h
>>> ==============================================================================
>>> --- head/sys/arm/include/intr.h      Wed Jan  1 19:38:15 2014        (r260160)
>>> +++ head/sys/arm/include/intr.h      Wed Jan  1 20:03:48 2014        (r260161)
>>> @@ -68,6 +68,7 @@
>>>  #endif
>>>
>>>  #include <machine/psl.h>
>>> +#include <sys/bus.h>
>>>
>>>  int arm_get_next_irq(int);
>>>  void arm_mask_irq(uintptr_t);
>>> @@ -77,6 +78,8 @@ void arm_setup_irqhandler(const char *,
>>>      void *, int, int, void **);
>>>  int arm_remove_irqhandler(int, void *);
>>>  extern void (*arm_post_filter)(void *);
>>> +extern int (*arm_config_irq)(int irq, enum intr_trigger trig,
>>> +    enum intr_polarity pol);
>>>
>>>  void gic_init_secondary(void);
>>>
>>
>> It turns out that the new #include in this change is causing the current
>> arm tinderbox failures.  Enums can't have forward decls anymore, so the
>> fix for this may not be easy.
>
> I posted my try to fix this here:
>
> http://lists.freebsd.org/pipermail/freebsd-current/2014-January/047694.html
>
> Rebuilt 260333 successfully with it.
>
> Andreas
>

Hello.

Thank you very much. Can this be committed or are there any objections?

Best regards
zbb