Date: Sun, 5 Aug 2012 10:53:57 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r239074 - head/usr.sbin/ctladm Message-ID: <20120805175357.GA50024@troutmask.apl.washington.edu> In-Reply-To: <201208051723.q75HNl80006961@svn.freebsd.org> References: <201208051723.q75HNl80006961@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 05, 2012 at 05:23:47PM +0000, Dimitry Andric wrote: > Author: dim > Date: Sun Aug 5 17:23:47 2012 > New Revision: 239074 > URL: http://svn.freebsd.org/changeset/base/239074 > > Log: > In usr.sbin/ctladm/ctladm.c, function cctl_error_inject(), initialize > the 'retval' variable to zero, to avoid returning garbage in several > cases. > > This fixes the following clang 3.2 warnings: > > usr.sbin/ctladm/ctladm.c:1234:6: error: variable 'retval' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > if (ioctl(fd, CTL_ERROR_INJECT, &err_desc) == -1) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dimitry can you wrap these long error messages to something shorter than 80 characters. The commit messages are otherwise pain to read. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120805175357.GA50024>