From owner-freebsd-net@FreeBSD.ORG Tue Jun 22 09:06:30 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A657F16A4CE; Tue, 22 Jun 2004 09:06:30 +0000 (GMT) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4550843D55; Tue, 22 Jun 2004 09:06:30 +0000 (GMT) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i5M96Kgd017409; Tue, 22 Jun 2004 02:06:20 -0700 (PDT) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i5M96KoH017408; Tue, 22 Jun 2004 02:06:20 -0700 (PDT) (envelope-from rizzo) Date: Tue, 22 Jun 2004 02:06:20 -0700 From: Luigi Rizzo To: Maxim Konovalov Message-ID: <20040622020620.A16578@xorpc.icir.org> References: <40D754D5.1070805@freebsd.org> <20040622115532.W5744@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20040622115532.W5744@mp2.macomnet.net>; from maxim@macomnet.ru on Tue, Jun 22, 2004 at 12:15:21PM +0400 cc: freebsd-net@freebsd.org cc: freebsd-current@freebsd.org cc: Andre Oppermann Subject: Re: New preview patch for ipfw to pfil_hooks conversion X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2004 09:06:30 -0000 On Tue, Jun 22, 2004 at 12:15:21PM +0400, Maxim Konovalov wrote: ... > > Consider this a FYI. It is very much a WIP at the moment. I want > > to get this into the tree in before 5.3 code freeze. > > In fact, our real world tests shown the current -CURRENT comparing to > RELENG_5_2 is in a very bad shape. Is it really worth to commit that > mostly cleanup code before say 6-CURRENT with a chance to of course it is! i also do not follow the reasoning -- given that it is cleaning up code, it is only welcome at any stage except perhaps in code freeze. plus, is the 'bad shape' related at all to what andre posted ? cheers luigi