From owner-freebsd-net@FreeBSD.ORG Fri Feb 1 12:40:10 2013 Return-Path: Delivered-To: net@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 1566E729; Fri, 1 Feb 2013 12:40:10 +0000 (UTC) (envelope-from bright@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 0738B240; Fri, 1 Feb 2013 12:40:09 +0000 (UTC) Received: from Alfreds-MacBook-Pro-9.local (ool-45775fce.dyn.optonline.net [69.119.95.206]) by elvis.mu.org (Postfix) with ESMTPSA id 5DC011A3DDA; Fri, 1 Feb 2013 04:39:59 -0800 (PST) Message-ID: <510BB79D.8040707@mu.org> Date: Fri, 01 Feb 2013 07:39:57 -0500 From: Alfred Perlstein User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: m_get2() name References: <20130201120414.GG91075@FreeBSD.org> In-Reply-To: <20130201120414.GG91075@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: net@FreeBSD.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2013 12:40:10 -0000 On 2/1/13 7:04 AM, Gleb Smirnoff wrote: > Hi! > > The m_get2() function allocates a single mbuf with enough space > to hold specified amount of data. It can return either a single mbuf, > an mbuf with a standard cluster, page size cluster, or jumbo cluster. > > It is alredy utilized in pfsync, bpf, libalias and soon to be utilized > in ieee802111. There are probably more places in stack where it can be used. > > The question is about its name. Once introduced, I just gave it name > "m_get2" to avoid discussion with myself about bikeshed colour and continue > hacking. Now it is getting used wider, and before we branch any stable branch > off the head, we have last chance to rename it to smth more meaningful. > > Any ideas on better name are welcome. > m_getbs - mbuf get buffer size. conveniently also maps to: m_getbs - mbuf get bike shed. This is a cool function. Maybe it should take an int*error arg as well for ENOBUFS/EINVAL? -Alfred