From owner-svn-ports-head@freebsd.org Fri May 17 12:36:02 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E7B615942E0; Fri, 17 May 2019 12:36:02 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DF8BA71B5D; Fri, 17 May 2019 12:36:01 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x52e.google.com with SMTP id j26so3261600pgl.5; Fri, 17 May 2019 05:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vqzI8CRxDQIDFHgO72mwfGoZSHfmbZEwWmxifXoyzIE=; b=XQyNjVXTdyVy0m3AznI8s9WUBdKXzEEIEdYP8tBU/nt65diV+09Ve9LHJ2QdHHCraH ymY2mktxz4ExOoA10lFGveIFAkjASMWMyIWqhWRkzxbFSRrwdsTh4iZT2x24SG1I3TXz hrzQGNWXaCrLaEekF9aFAs8DdHiNMGUHGaoQco+MsX/8UdkNP2q6wVjICxParLZNQTEW twbKGa3x1QVlgMeUU7WTnA0omepLJR1DkXuy/lZ3TLZbT/MjQMBx4UHIX996AB7ho5zC HU6JG9AWByusW3hebzkvGEb4qlZnvJUeDrB4egJ6+dBi3sJ4yPZANrsjinf8aO3zCw/Y b21w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vqzI8CRxDQIDFHgO72mwfGoZSHfmbZEwWmxifXoyzIE=; b=E3wCRyhMk+VP0UCAa1FGzip4wIjy/nghH5JxgHfWayyCCf2f7hi3eR4Cbxv5unrw48 kyFkxgDzILKJ7kB84zPNAJyR23lx9XrLWgfCE6DM7N1xYEYouq8zq4fkgOIn7pLMCcFT 6+yYXXr3Jb6nrCvESr5g/RW6T98KI4OYgRuxQiBDytWKVeqeXXibLMIobaDf6vtDJnST HnggG+NIxGSfkkB4qVmF4aF0mX+c1zObq8ofcJcJpzSj6wLkfva9j7gkMgw8jZ19BKeT TnSjfbQRI6jAVOS0M2l+D7ar8GY7BePWUmaMQfcYu8hqj4bX0DxGb4IiNfIxpQQF31x6 ZWiw== X-Gm-Message-State: APjAAAWMLXCkWD8kDCnYjYAVEva9EGi6lhscrHSEwyDTUnPnxcpGuyPg 8DsEoz8qb9RHObtIg0OCbc6wOuP6 X-Google-Smtp-Source: APXvYqxvKK0OTM9cXiDi6fU6vWefxm+knw5R8pff3YdGL4LhxW93B8gSfSeCMCa4px5vTnmGTgNpjg== X-Received: by 2002:a63:5c5b:: with SMTP id n27mr57102034pgm.52.1558096560569; Fri, 17 May 2019 05:36:00 -0700 (PDT) Received: from [192.168.1.105] (121-200-20-216.79c814.syd.nbn.aussiebb.net. [121.200.20.216]) by smtp.gmail.com with ESMTPSA id b18sm18497577pfp.32.2019.05.17.05.35.58 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 05:36:00 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r501839 - head/www/py-websocket-client To: Antoine Brodin Cc: ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201905170822.x4H8MRgW081754@repo.freebsd.org> <186d3850-2cf7-bac4-f568-2c370c3554bc@FreeBSD.org> From: Kubilay Kocak Message-ID: Date: Fri, 17 May 2019 22:35:56 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Thunderbird/67.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DF8BA71B5D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.92)[-0.924,0]; TAGGED_FROM(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2019 12:36:02 -0000 On 17/05/2019 9:41 pm, Antoine Brodin wrote: > On Fri, May 17, 2019 at 12:58 PM Kubilay Kocak wrote: >> Thanks Antoine, but what was the actual error observed? >> >> I QA'd this pretty thoroughly (including a full test suite run/pass) so >> it would be handy to know the exact failure mode >> >> Python > 2.7.9 has match_hostname and websocket-client checks for the >> stdlib before falling back to backports: >> >> if hasattr(ssl, "match_hostname"): >> from ssl import match_hostname >> else: >> from backports.ssl_match_hostname import match_hostname > > Did you check the generated package? > > # cat /usr/local/lib/python2.7/site-packages/websocket_client-0.56.0-py2.7.egg-info/requires.txt > six > backports.ssl_match_hostname > > Antoine > Ahh the simple things. Thanks for the detail