From owner-svn-src-stable-10@FreeBSD.ORG Wed May 27 19:30:36 2015 Return-Path: Delivered-To: svn-src-stable-10@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 22BED7DF; Wed, 27 May 2015 19:30:36 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qc0-x22a.google.com (mail-qc0-x22a.google.com [IPv6:2607:f8b0:400d:c01::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D02BFCAA; Wed, 27 May 2015 19:30:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by qchk10 with SMTP id k10so8402679qch.2; Wed, 27 May 2015 12:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=irGtmwiHldn0fMgv7X2+Isk54+TrBuZ5mDtMqVfU+j0=; b=H8jkrwdY5aiSGX3sb+/NjJr5cj8hAExvup3FVXyECTzKwfa+ID8xq8VJyxhpM9pTLH wRuriDalPEDNsShrW/4M5hReTxsU7uWXNaRWp+/7M/IeAMORHFms+Z72NqPqy/d+vjmk +wd3SWBDgjNVEKQad7ZrHHwaWoWHFK1Q/A4Kmg6fulmffR5/vyO57KCjDKIQRfe8Zp3J KVtvgXoU7c9TgkU2dQr9dawiUKZ7wjuJMtce1pCNC2TOLfuLLgmdLwAq0EceXxYbULUO IyKm+Aqc7dg86IHWOjK7O8n+zlHDuR7PxJaRdgBYEJLL2MtP3YeNq6nDLOxd3ftKYOGb Irqw== MIME-Version: 1.0 X-Received: by 10.140.90.99 with SMTP id w90mr41451597qgd.57.1432755035032; Wed, 27 May 2015 12:30:35 -0700 (PDT) Received: by 10.140.98.73 with HTTP; Wed, 27 May 2015 12:30:34 -0700 (PDT) In-Reply-To: <16669147.Y9s9XdOlga@ralph.baldwin.cx> References: <201505271744.t4RHiC04024525@svn.freebsd.org> <16669147.Y9s9XdOlga@ralph.baldwin.cx> Date: Wed, 27 May 2015 12:30:34 -0700 Message-ID: Subject: Re: svn commit: r283620 - in stable/10/sys: amd64/conf conf dev/ixgbe modules modules/ix modules/ixv From: NGie Cooper To: John Baldwin Cc: Eric Joyner , Jack F Vogel , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-10@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 19:30:36 -0000 On Wed, May 27, 2015 at 12:09 PM, John Baldwin wrote: > On Wednesday, May 27, 2015 05:44:12 PM Eric Joyner wrote: >> Author: erj >> Date: Wed May 27 17:44:11 2015 >> New Revision: 283620 >> URL: https://svnweb.freebsd.org/changeset/base/283620 >> >> Log: >> MFC ixgbe commits for 10.2: >> >> - r280182 - Split the driver into independent pf/vf loadables >> - r280197 - Resolve build issues >> - r280204 - Fix multiple same-name devclasses >> - r280228 - Fix i386 LINT build issues / remove unused variable >> - r280252 - Fix building ixgbe with gcc >> - r280962 - Make changes to busdma code similar to r257541 >> - r281772 & r281773 - Remove unused variable >> - partial r282280 - stats counter update (ix-only) >> - r282289 - Add X550 support >> - r282290 - Add X550 makefile updates >> - r282293 - Add ixgbe_x550.c to conf/files >> - r282299 - Fix gcc compile (extraneous extern declaration) >> >> Finally, add ix_txrx.c to conf/files because it's required for compile in stable/10. >> >> Approved by: jfv (mentor) > > It would be better to not break existing kernel configs for 10. You could > hack the lines in sys/conf/files to allow either 'device ix' or 'device ixgbe' > to work by using 'optional ixgbe ix', etc. You wouldn't need to document it > in NOTES and you could leave your existing changes in GENERIC, but this would > avoid surprises for folks who were using custom kernel configs. > > Similarly, you probably want to allow 'kldload ixgbe' or 'ixgbe_load="YES"' > in loader.conf to still work. You can try just installing an 'ixgbe.ko' > symlink via the module's Makefile, though I'm not sure that will work > correctly for the loader.conf case. If it doesn't, then the other route is > to create a stub ixgbe.c file that MODULE_DEPEND()'s on the ix and ixv driver > modules so that it autoloads if_ix.ko and if_ixv.ko as dependencies when it > is loaded. +100