Date: Sat, 18 Oct 2003 16:34:26 -0400 From: Eduard Martinescu <martines@rochester.rr.com> To: Oliver Eikemeier <eikemeier@fillmore-labs.com> Cc: Sergey Matveychuk <sem@ciam.ru> Subject: Re: ports/58085: New Port: S.M.A.R.T. disk monitoring tools Message-ID: <1066509266.2933.20.camel@firestorm.crafts4life.com> In-Reply-To: <3F91636F.3070701@fillmore-labs.com> References: <200310181410.h9IEAKhS076253@freefall.freebsd.org> <3F91636F.3070701@fillmore-labs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-b2MyVZlfj1xW66A1aTxo
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Thank you for your suggestions...
I have updated the shar file 1 more time to incorporate the changes
below. As this is my first time submitting a port, I really appreciate
the pointers.
Thanks,
Ed
On Sat, 2003-10-18 at 11:59, Oliver Eikemeier wrote:
> Hi Eduard,
>
> just some minor suggestions ;->
>
> > XCONFIGURE_ARGS+= --with-initscriptdir=${PREFIX}/etc/rc.d --with-docdir=${PREFIX}/share/doc/smartmontools --enable-sample
> I assume you meant --with-docdir=${DOCSDIR} here?
>
> > X @${INSTALL_MAN} ${WRKSRC}/smartctl.8 \
> > X ${PREFIX}/man/man8
> > X @${INSTALL_MAN} ${WRKSRC}/smartd.conf.5 \
> > X ${PREFIX}/man/man5
> > X @${INSTALL_MAN} ${WRKSRC}/smartd.8 \
> > X ${PREFIX}/man/man8
> You could use ${MAN5PREFIX}/man/man5 and ${MAN8PREFIX}/man/man8 here,
> in case someone installs the port with PREFIX=/usr
>
> > X @${INSTALL_DATA} ${WRKSRC}/COPYING ${DOCSDIR}
> Form the FreeBSD Porter's Handbook, 15.19 Miscellanea:
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-misc.html
>
> "Do not copy more copies of the GNU General Public License into our system, please."
>
> Regards
> Oliver
--
Eduard Martinescu <martines@rochester.rr.com>
--=-b2MyVZlfj1xW66A1aTxo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1066509266.2933.20.camel>