From owner-freebsd-bugs Thu Jul 9 01:35:52 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA17743 for freebsd-bugs-outgoing; Thu, 9 Jul 1998 01:35:52 -0700 (PDT) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from critter.freebsd.dk (critter.freebsd.dk [195.8.133.1] (may be forged)) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA17738 for ; Thu, 9 Jul 1998 01:35:49 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.8.7/8.8.5) with ESMTP id KAA06663; Thu, 9 Jul 1998 10:32:38 +0200 (CEST) To: smoergrd@oslo.geco-prakla.slb.com (Dag-Erling Coidan Smørgrav) cc: akiyama@kme.mei.co.jp, freebsd-bugs@FreeBSD.ORG Subject: Re: kern/7210 In-reply-to: Your message of "09 Jul 1998 10:22:50 +0200." Date: Thu, 09 Jul 1998 10:32:37 +0200 Message-ID: <6661.899973157@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org In message , Dag-Erling Coidan Smørgra v writes: >Poul-Henning Kamp writes: >> Synopsis: [PATCH] od(4) bug fixes and enhancements, including LF-D100 DVD-RAM drive support. >> >> State-Changed-From-To: open-closed >> State-Changed-By: phk >> State-Changed-When: Wed Jul 8 23:27:12 PDT 1998 >> State-Changed-Why: >> please don't mix three so different things in the same patch >> please resubmit as three PRs > >Poul-Henning, as much as I appreciate the need to reduce the number of >PRs, I think this was a little gratuitous. The patch fixes at least >two serious (and related) bugs in the od driver, and should be treated >a little more seriously. Yes, which I why I ask the submitter to split it for us. Experience has shown that "jumbo patches" never get touched, whereas patches that solve one problem only are much more likely to be fixed. there for the "please resubmit as three PRs" reply. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." "ttyv0" -- What UNIX calls a $20K state-of-the-art, 3D, hi-res color terminal To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message