From owner-freebsd-gnome@FreeBSD.ORG Sun Aug 29 16:22:26 2010 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A451C10656A6 for ; Sun, 29 Aug 2010 16:22:26 +0000 (UTC) (envelope-from marcus@freebsd.org) Received: from av-tac-rtp.cisco.com (hen.cisco.com [64.102.19.198]) by mx1.freebsd.org (Postfix) with ESMTP id 620838FC18 for ; Sun, 29 Aug 2010 16:22:26 +0000 (UTC) X-TACSUNS: Virus Scanned Received: from rooster.cisco.com (localhost.cisco.com [127.0.0.1]) by av-tac-rtp.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id o7TGMPsl003718; Sun, 29 Aug 2010 12:22:25 -0400 (EDT) Received: from fruit-rollup.marcuscom.com (jclarke-pc.cisco.com [172.18.254.236]) by rooster.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id o7TGMKws007746; Sun, 29 Aug 2010 12:22:21 -0400 (EDT) Message-ID: <4C7A893C.2070000@freebsd.org> Date: Sun, 29 Aug 2010 12:22:20 -0400 From: Joe Marcus Clarke Organization: FreeBSD, Inc. User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 MIME-Version: 1.0 To: Andriy Gapon References: <20100827001412.C8B381CC3A@ptavv.es.net> <4C79635A.7030101@freebsd.org> <4C796B4E.8020704@icyb.net.ua> <4C798B36.3040300@freebsd.org> <4C7A2885.9000306@icyb.net.ua> In-Reply-To: <4C7A2885.9000306@icyb.net.ua> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: gnome@freebsd.org Subject: Re: ports/149134: x11/gnome2 unable to unmount UFS file system X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Aug 2010 16:22:26 -0000 On 8/29/10 5:29 AM, Andriy Gapon wrote: > on 29/08/2010 01:18 Joe Marcus Clarke said the following: >> On 8/28/10 4:02 PM, Andriy Gapon wrote: >>> on 28/08/2010 22:28 Joe Marcus Clarke said the following: >>>> >>>> Try http://www.marcuscom.com/downloads/patch-hald_hf-storage.c >>> >>> Just wondering aloud... Would the same strange things (mentioned in the comment >>> in the patch) happen with labels for other filesystems like msdos/ cd9660/ ? >>> Or it's something specific to UFS? >>> >> >> Yeah, it could happen for other labels, I suppose. The problem is that >> the labels that appear dynamically depending oh whether or not a device >> is mounted confuses hal. If someone mounts /dev/cd0, unmounts it, then >> sees /dev/cd9660/FREEBSD appear, that will cause hal to think a new >> device was inserted. >> >> That said, I've only seen this happen with UFS. > > > BTW, there seems to be an exclamation mark missing in the following part of the > patch (hope you use monospaced font): > > + ! strcmp(fields[1], "PART")) && > + ! (strncmp(fields[2], "ufsid/", strlen("ufsid/")) || > Here----------^ > + ! strncmp(fields[2], "ufs/", strlen("ufs/")))) > > Ugh, you're right. When I added "ufs/" to the list, I broke the logic. It should be fixed now. Joe -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome