From nobody Sat Oct 14 01:08:44 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S6lcs0gLYz4x3s5; Sat, 14 Oct 2023 01:08:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S6lcs00xVz3Wt1; Sat, 14 Oct 2023 01:08:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697245725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+2Vw0eMhO6jOYt7iNa/mVpWk9J0oqLLUT3VP3QuteFI=; b=eiLAg8+WR36lToivWy+XwEojGUv8rc83BrqqsXRDVQBRc+GSN+7je20l326H0N40blz+uA rE0JdKFQDjn4qLviWzAHs/+BYW2XbvINnU/Rk+QZH3v9pzP6ihXzxQH7PN0S71QopKhbEV CjXGvRadOgTQcJJN0kb2kNLAu7QjZD4Xb7tsPQBAjXTLle8owP3OXumKlflbAmHcaBSryT YqzDqfKml/BY+IzPYV/4lETDTFR/bI0KHWtGJtYRefoRdpwtC694pDwdhSPJ751f7KF3K/ 5f/TWMPkJ+oV+j8uYGWkBrX3sHwacQGhujVAHzsieS/1p3CTivN2zwbRNupZFQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697245725; a=rsa-sha256; cv=none; b=pSA/Jd+mpOX/GNJg5XUqzRH/BJwkEAaFjEpfhfckLclczBU/wvvoMtKGrmw2S2VJOcnf9Q 0sX/jjxMYIvJjYj5y0cwIPdZTJlCsTVJLkQrAilD+h8rujivCTkspRwI3nHHomMFeHPwz1 doXg+bY5qmkwtDmzK/y/4E3tRsef+B4SDVJAOOwMuVQ+k4A2VYTeLyzaBSGnF18OzXNUQD dvIniQCKAJ7HhFOTVmMeONH2bQsXlIr59leeE7C9Zjgr/g8MOtt+JwEqCZqtp88Qj0/gev zF5sQOdBMa9wV8JjvECo4tz7toIuln3cy2c7PDrHNcUYoIL3dr4jJvusqLiYag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697245725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+2Vw0eMhO6jOYt7iNa/mVpWk9J0oqLLUT3VP3QuteFI=; b=ggxkUZ4V6xtd9ch60TU0ZtE9Kp/f6h3A5+lEUjY+gO2LyTkgqDPEuH+NA/uV00G6DiiFU3 W1Jzrz19NMB68KT5TT2BnghcKrgbJaJB4Mt/GZf1YmqcETFvkTpFI0q14gIM5HdkchEHvE 71YREIMiFW14wDi4bFaSYz1hfo/xS7KEN2L18BTkfVJf1inwyfBDCL5cW+xMi662GrhfDb wKYqgNLmZySKBo0C59HrygbImjDWMXBj+pJSPBjdhtWgbVN0M2+RxX+LgT9FNAGY0jGcm0 17Ae0BuglEB3YTjUpbpNFRfIFL+r6aSVbzMCyFQXFCp0A6hyECb2iKBUSq8EHQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S6lcr5pnKz19BV; Sat, 14 Oct 2023 01:08:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39E18iJ8052054; Sat, 14 Oct 2023 01:08:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39E18iJC052051; Sat, 14 Oct 2023 01:08:44 GMT (envelope-from git) Date: Sat, 14 Oct 2023 01:08:44 GMT Message-Id: <202310140108.39E18iJC052051@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 06e001a7666d - releng/14.0 - vfs cache: retire dothits and dotdothits counters List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: 06e001a7666d8b8d8d2514c94a2c3026f6a6b79f Auto-Submitted: auto-generated The branch releng/14.0 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=06e001a7666d8b8d8d2514c94a2c3026f6a6b79f commit 06e001a7666d8b8d8d2514c94a2c3026f6a6b79f Author: Mateusz Guzik AuthorDate: 2023-09-23 00:08:49 +0000 Commit: Mateusz Guzik CommitDate: 2023-10-14 01:06:12 +0000 vfs cache: retire dothits and dotdothits counters They demonstrate nothing, and in case of dotdot they are not even hits. This is just a count of lookups with "..", which are not worth mentioniong. (cherry picked from commit bb124a0f611a1288c8496e3b33494f23ba929ca1) (cherry picked from commit 0cf6ebad73640a20fe99adacba635e2630be5d08) Approved by: re (gjb --- sys/kern/vfs_cache.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index 631ce856efdf..62213d94d8e2 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -530,8 +530,6 @@ STATNODE_ULONG(neg, numneg, "Number of negative cache entries"); STATNODE_ULONG(count, numcache, "Number of cache entries"); STATNODE_COUNTER(heldvnodes, numcachehv, "Number of namecache entries with vnodes held"); STATNODE_COUNTER(drops, numdrops, "Number of dropped entries due to reaching the limit"); -STATNODE_COUNTER(dothits, dothits, "Number of '.' hits"); -STATNODE_COUNTER(dotdothits, dotdothits, "Number of '..' hits"); STATNODE_COUNTER(miss, nummiss, "Number of cache misses"); STATNODE_COUNTER(misszap, nummisszap, "Number of cache misses we do not want to cache"); STATNODE_COUNTER(poszaps, numposzaps, @@ -1782,7 +1780,6 @@ cache_lookup_dot(struct vnode *dvp, struct vnode **vpp, struct componentname *cn int ltype; *vpp = dvp; - counter_u64_add(dothits, 1); SDT_PROBE3(vfs, namecache, lookup, hit, dvp, ".", *vpp); if (tsp != NULL) timespecclear(tsp); @@ -1827,7 +1824,6 @@ cache_lookup_dotdot(struct vnode *dvp, struct vnode **vpp, struct componentname return (0); } - counter_u64_add(dotdothits, 1); retry: dvlp = VP2VNODELOCK(dvp); mtx_lock(dvlp); @@ -5131,7 +5127,6 @@ cache_fplookup_dot(struct cache_fpl *fpl) fpl->tvp = fpl->dvp; fpl->tvp_seqc = fpl->dvp_seqc; - counter_u64_add(dothits, 1); SDT_PROBE3(vfs, namecache, lookup, hit, fpl->dvp, ".", fpl->dvp); error = 0; @@ -5220,7 +5215,6 @@ cache_fplookup_dotdot(struct cache_fpl *fpl) return (cache_fpl_aborted(fpl)); } - counter_u64_add(dotdothits, 1); return (0); }