From nobody Wed Nov 23 10:00:09 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NHGp41Tpdz4jFhF; Wed, 23 Nov 2022 10:00:12 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NHGp411nJz4KKd; Wed, 23 Nov 2022 10:00:12 +0000 (UTC) (envelope-from bapt@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669197612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3QKuXbXTdfnegszgSpYNNf1g0Z9Zo4iRfmfQMrbVe2c=; b=HME6KggmTVuXXa56SSzbsh80D+XVEcg/J8x1Rx+vVOy+cm8q26+giVReNq9DHZNSeSbjno Q+3Zr9uy/ic4Ey+3WQxT4DhNQtSYe4Il3Wbvo7n3+x0N8UkitdGJPOUNOpzif2FXZQ6k56 CyXLPisgql/hwT3DIoiMA5ZK6RTuN9UHmdxZehO4rzYUeFWBzZJvP0BQtludGhVXRFphuf UinhFg9RVEuHoS3rXupqIWBZQaW1lscgaE2jOipPzWEC2rCdIT+xAlw9CqVG5UJssBE39u By6iJFSg0xkSyc/d9qJBoBzZbgtwoim9J64Qkohj5rkE3lPpJGO4gnnxms5KSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669197612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3QKuXbXTdfnegszgSpYNNf1g0Z9Zo4iRfmfQMrbVe2c=; b=HHIVk4inmnhpLuRnAme+dKuixK/KnbvYDFkBE4EqORmSXawHHB+E3W8CqCCOlNdCyfcsq4 /PUm2Gib3MJekXWwqo6LmsAd+Ojp85gnYc7UNQygcNMocTQMqWvEIPbarqvI+QwD2yM1dy zWH6Iz9ZAeL98fnKlqCJjw4bAzFXleWcwl2Fgolqh7DvX1daETBZbGhT5e3rz6Z1AkM4Bn EJ+l6F1PSjbaJ8eUtr24X9wK6dzbTCRju4NI4QK4a97lEwNrBy2IJj3Boac/hPNIc75lI+ D/+JQ8ZDele7Rn3V07/Vm0SzPEHt2yIGtgGKng67jGsxsAX2RmhRCRkE7g4zpw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669197612; a=rsa-sha256; cv=none; b=yziicvyyU9VD2NbKvdv2CD+34t9uK5RRRpokHygLRRZPZRhY2H68tflIp76ZuXq2p5TyOE ls2dN0b+7wHmNHd+EYnqZ4mqV6TBOFk74rGMrCxgc+/Sfp8ewFouAAKUat26kk1uJHQJNE BbunHdVi+pYD4YHw2qgMLPC2vBMvJy7UswruNaoIp2iq+bVgyDR+lyjnnQoTznY8kN777n dW/ZfIUIUJnF/yTG6EATWzmEC7uCSKQXvcz0xfrA3qKEwd1ci09ukfQ9JU34C5oP/s9FS+ fworW98IkJNPZBYK9tAWe9GLUTgk3yPi8R6KncN+sFuiqINxo6R/wRLle7Hqhg== Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NHGp36Rhkznpm; Wed, 23 Nov 2022 10:00:11 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id CB3F91826AE; Wed, 23 Nov 2022 11:00:09 +0100 (CET) Date: Wed, 23 Nov 2022 11:00:09 +0100 From: Baptiste Daroussin To: Jochen Neumeister Cc: Ryan Steinmetz , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 1867f0afa761 - main - www/nginx: Update 3rd Party Modules: ip2location, ip2proxy Message-ID: <20221123100009.t37svlib2kzvn2nl@aniel.nours.eu> References: <202211201906.2AKJ6Z7K081843@gitrepo.freebsd.org> <58629f2e-5e5b-6598-f801-f14870ea0ed9@FreeBSD.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58629f2e-5e5b-6598-f801-f14870ea0ed9@FreeBSD.org> X-ThisMailContainsUnwantedMimeParts: N On Mon, Nov 21, 2022 at 09:48:07AM +0100, Jochen Neumeister wrote: > Is it now allowed to edit the port without informing the maintainer? I think > we have rules here, right? > I can't find any PR or eMail where this update is requested. > Also, PORTREVISION was not pumped. > Hello everyone, joneum@ is right here! here we have 2 issues: 1/ A simple technical one: the package has changed and such it deserves a bump of portrevision. 2/ The other one, is the following, while we have a blanket for fixes and framework changes adaptations, it does not include upgrades even simple ones. And we have to at least send a heads up to the maintainear anyway. (Yes I know I sometime myself forget about the maintainer heads up and I am trying to fix myself) Also mistake can happen, because someone wants to go fast or for any $reason, if so, then it is important to be reactive. Here a bump of the portrevision should have been pushed quickly after the maintainer pointed at the error. Last acknowledging the issue is part of what we can expect from a committer. Best regards, Bapt