From owner-svn-ports-all@freebsd.org Fri Oct 12 17:50:14 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2339110C51F2; Fri, 12 Oct 2018 17:50:14 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from ihor-3.amdmi3.ru (ihor-3.amdmi3.ru [185.117.152.228]) by mx1.freebsd.org (Postfix) with ESMTP id ABD5F8DE03; Fri, 12 Oct 2018 17:50:13 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from amdmi3.ru (localhost [127.0.0.1]) by ihor-3.amdmi3.ru (Postfix) with SMTP id 173DE1AF11D; Fri, 12 Oct 2018 20:50:05 +0300 (MSK) Received: by amdmi3.ru (nbSMTP-1.00) for uid 1000 amdmi3@amdmi3.ru; Fri, 12 Oct 2018 20:50:05 +0300 (MSK) Date: Fri, 12 Oct 2018 20:41:30 +0300 From: Dmitry Marakasov To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, portmgr@FreeBSD.org, perl@FreeBSD.org Subject: Re: svn commit: r481365 - in head: archivers/p5-Archive-Any archivers/p5-Archive-Any-Plugin-Rar archivers/p5-Archive-Extract-Libarchive archivers/p5-Archive-Peek archivers/p5-Archive-Rar archivers/p5-A... Message-ID: <20181012174130.GF79805@hades.panopticon> References: <201810061306.w96D6jJe040138@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201810061306.w96D6jJe040138@repo.freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 17:50:14 -0000 * Dag-Erling Smørgrav (des@FreeBSD.org) wrote: > Author: des > Date: Sat Oct 6 13:06:42 2018 > New Revision: 481365 > URL: https://svnweb.freebsd.org/changeset/ports/481365 > > Log: > Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except > for where it resulted in a change in output from build-depends-list or > run-depends-list. > > Approved by: portmgr (adamw) What exactly is this `fixing'? This is explicitly stated in PHB 5.9.2 as wrong: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#makefile-run_depends > -BUILD_DEPENDS= p5-Object-Tiny>=0:devel/p5-Object-Tiny > -RUN_DEPENDS:= ${BUILD_DEPENDS} > +BUILD_DEPENDS= ${RUN_DEPENDS} > +RUN_DEPENDS= p5-Object-Tiny>=0:devel/p5-Object-Tiny After this change, if something is added to RUN_DEPENDS, it'll end up in BUILD_DEPENDS as well. This already leads to perl being mentioned in BUILD_DEPENDS twice. Here's another example: % grep nmap /usr/ports/net-mgmt/p5-FusionInventory-Agent/Makefile NETDISC_RUN_DEPENDS= nmap:security/nmap \ The intent is clearly for nmap to be added to run depends only. But: % WITH=NETDISC make -C /usr/ports/net-mgmt/p5-FusionInventory-Agent -V RUN_DEPENDS | grep -o ' nmap' nmap % WITH=NETDISC make -C /usr/ports/net-mgmt/p5-FusionInventory-Agent -V BUILD_DEPENDS | grep -o ' nmap' nmap -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: https://github.com/AMDmi3