From nobody Mon Jul 27 10:17:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h7vfS5nYDz6mlMm for ; Mon, 27 Jul 2026 10:17:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h7vfS2mYyz3LFM for ; Mon, 27 Jul 2026 10:17:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785147440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=26m1ElDhk9jZBPAQw4zpisjthf+yyDDcWhzMXX2Lo9s=; b=NugSP17g0EESTR7NFgZyCUtYygnJ4z/LOoaW3IVo98iHWHFxHA4fAc9D7lUg0BZen50ebd aw2oRZKtzaBi2fKFJtQ9AUU/WuFyye+juE8p2dp+0IVhYYIy1yphdaKUh+LntrxdsqO0yt ZIWHwAfrJcvZyQXUQq6eOom8WlMdvWGppKEGxwRr9HRwTsm2wNqVCNkEAdLPQN6VLmncFp 6O97RRy0bw8ImcsJ8fpOeLAceZ/CbixyyEEWLneUL+dSwLbqOeILqoYttcGQp7IbqaPQWy wC89rPTTImesADgZwZ/67oI1ecRTCSG8wbiaQYud2khzsz3FUuxMyKECOOUOWg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785147440; a=rsa-sha256; cv=none; b=ozD4v8XXtWQhKhUN45RAkQ0mnRGKtXyXjum5G7JInu2i61LmcSumcfxKMOdJDjgA/zEwLC KRaSHZlK7UwC3ZHO3Dgxk4ESqHG5Wx1/f6obgnxzOFXwj0vkTfPvjB8Hs7DPcxNugY4LYM pu/CR8FXpmDILvgPyc61ThADXmfu65cjYLWiC6T8IlqR+s2IjmGPdiIruEFU0uDM6Hui6R kkRv8cG+MvwbMQ07Uu5vqlZjiUkkVdg8y0h9STIgM+l+xa+U8t9WMIRZjVnidv/SuQ6UKS xcQ5i6LRLzMFQf1XJElRe5E9lgpXz40ER+kWBi23Y9Ja8QVg7XV35Js9sVo8Qw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785147440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=26m1ElDhk9jZBPAQw4zpisjthf+yyDDcWhzMXX2Lo9s=; b=cHrWLvfnkTsqCJXY1Rj+JSlA7Aa/lW0JUWrwPMHhf/uSBaQ5KY1WMV/zYCNFeqV3VnLh+i lr2KD0mP+mR9pusReGvLMnTl2ViQJYrxGDKgIIJZq81pI0BQCp/i68ZiMW0nqDsOqad2Ym VBNr27VCVg7KJa6S/QHQzE++kUdF6Il0jnxAZuxtPjVlxk3sCXUoFOgOYCjntgTBwxufAR bKm+VxX+/Ur+JTXdf0X96/zcKI+WN1umkVnik0c0ZYgzjmA07iagrRm3c2r/8zmuXrEs1b jzNrAEgcqGVYh83vWUqVO3zxPatav1ZMCTp6+rRVBNxGIPgoQiB4uIbIJCUcUg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h7vfS193Wz149Y for ; Mon, 27 Jul 2026 10:17:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f99c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 27 Jul 2026 10:17:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: e115066370dc - main - pwait: Test the new -r option List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e115066370dcfec410d914362756d09c268a5b4e Auto-Submitted: auto-generated Date: Mon, 27 Jul 2026 10:17:20 +0000 Message-Id: <6a673030.1f99c.1896476@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=e115066370dcfec410d914362756d09c268a5b4e commit e115066370dcfec410d914362756d09c268a5b4e Author: Dag-Erling Smørgrav AuthorDate: 2026-07-27 10:15:41 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-07-27 10:15:41 +0000 pwait: Test the new -r option Test that pwait without -r reports a process as soon as it terminates, while pwait with -r does not report it until it has been reaped. MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D58385 --- bin/pwait/tests/Makefile | 1 + bin/pwait/tests/pwait_reap.c | 188 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 189 insertions(+) diff --git a/bin/pwait/tests/Makefile b/bin/pwait/tests/Makefile index 4e355ccfe787..0f9359c92593 100644 --- a/bin/pwait/tests/Makefile +++ b/bin/pwait/tests/Makefile @@ -1,3 +1,4 @@ +ATF_TESTS_C= pwait_reap ATF_TESTS_SH= pwait_test .include diff --git a/bin/pwait/tests/pwait_reap.c b/bin/pwait/tests/pwait_reap.c new file mode 100644 index 000000000000..96c036ba2059 --- /dev/null +++ b/bin/pwait/tests/pwait_reap.c @@ -0,0 +1,188 @@ +/*- + * Copyright (c) 2026 Dag-Erling Smørgrav + * + * SPDX-License-Identifier: BSD-2-Clause + */ + +#include + +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +/* + * Wait for a process to terminate, optionally reap it, and verify that it + * exited cleanly. + */ +static void +wait_zero(pid_t pid, bool reap) +{ + int wstatus; + pid_t ret; + + do { + ret = waitpid(pid, &wstatus, reap ? 0 : WNOWAIT); + ATF_REQUIRE(ret == pid || (ret < 0 && errno == EINTR)); + } while (ret != pid); + ATF_CHECK(WIFEXITED(wstatus)); + ATF_CHECK_EQ(WEXITSTATUS(wstatus), 0); +} + +/* + * Verify that pwait is still waiting for the target process. + */ +static void +pwait_is_waiting(pid_t pwpid, pid_t tpid, int pwout, int pwerr) +{ + struct pollfd pfds[2]; + char line[64] = "", *eol, *rest; + ssize_t ret; + + pfds[0].fd = pwout; + pfds[0].events = POLLIN; + pfds[1].fd = pwerr; + pfds[1].events = POLLIN; + + /* loop until we have some output */ + do { + /* send SIGINFO so pwait prints the target PID on stderr */ + ATF_REQUIRE(kill(pwpid, SIGINFO) == 0); + } while ((ret = poll(pfds, 2, 100)) == 0); + ATF_REQUIRE_EQ(ret, 1); + ATF_REQUIRE_EQ(pfds[1].revents, POLLIN); + + /* read line from stderr */ + ATF_REQUIRE((ret = read(pwerr, line, sizeof(line) - 1)) > 0); + + /* verify the line */ + ATF_REQUIRE((eol = strchr(line, '\n')) != NULL); + *eol = '\0'; + ATF_REQUIRE_EQ(strtol(line, &rest, 10), tpid); + ATF_REQUIRE_STREQ(rest, ""); +} + +/* + * Verify that pwait has reported that the target process has terminated, + * then reap it. + */ +static void +pwait_is_done(pid_t pwpid, pid_t tpid, int pwout, int pwerr) +{ + struct pollfd pfds[2]; + char line[64] = "", *eol, *rest; + ssize_t ret; + + pfds[0].fd = pwout; + pfds[0].events = POLLIN; + pfds[1].fd = pwerr; + pfds[1].events = POLLIN; + + /* loop until we have some output */ + do { + /* nothing */ + } while ((ret = poll(pfds, 2, 100)) == 0); + ATF_REQUIRE_EQ(ret, 1); + ATF_REQUIRE_EQ(pfds[0].revents, POLLIN); + + /* read line from stdout */ + ATF_REQUIRE((ret = read(pwout, line, sizeof(line) - 1)) > 0); + + /* verify the line */ + ATF_REQUIRE((eol = strchr(line, '\n')) != NULL); + *eol = '\0'; + ATF_REQUIRE_EQ(strtol(line, &rest, 10), tpid); + ATF_REQUIRE_STREQ(rest, ": exited with status 0."); + + /* reap pwait */ + wait_zero(pwpid, true); +} + +static void +pwait_reap_test(bool reap) +{ + char pidstr[16]; + pid_t tpid, pwpid; + int tpipe[2], pwout[2], pwerr[2]; + + /* fork target process */ + ATF_REQUIRE(pipe2(tpipe, O_CLOEXEC) == 0); + ATF_REQUIRE((tpid = fork()) >= 0); + if (tpid == 0) { + (void)close(tpipe[1]); + /* block until parent closes its end of the pipe */ + (void)read(tpipe[0], pidstr, 1); + _exit(0); + } + (void)close(tpipe[0]); + + /* fork pwait */ + snprintf(pidstr, sizeof(pidstr), "%ld", (long)tpid); + ATF_REQUIRE(pipe2(pwout, O_CLOEXEC) == 0); + ATF_REQUIRE(pipe2(pwerr, O_CLOEXEC) == 0); + ATF_REQUIRE((pwpid = fork()) >= 0); + if (pwpid == 0) { + (void)dup2(pwout[0], STDOUT_FILENO); + (void)dup2(pwerr[0], STDERR_FILENO); + execlp("pwait", "pwait", reap ? "-rv" : "-v", pidstr, NULL); + _exit(99); + } + + /* wait for pwait to become ready */ + pwait_is_waiting(pwpid, tpid, pwout[1], pwerr[1]); + + /* unblock the target and wait for it to terminate */ + (void)close(tpipe[1]); + wait_zero(tpid, false); + + if (reap) { + /* check that pwait is still waiting */ + pwait_is_waiting(pwpid, tpid, pwout[1], pwerr[1]); + } else { + /* check that pwait has reported completion */ + pwait_is_done(pwpid, tpid, pwout[1], pwerr[1]); + } + + /* reap the target */ + wait_zero(tpid, true); + + if (reap) { + /* check that pwait has reported completion */ + pwait_is_done(pwpid, tpid, pwout[1], pwerr[1]); + } +} + +ATF_TC(pwait_normal); +ATF_TC_HEAD(pwait_normal, tc) +{ + atf_tc_set_md_var(tc, "descr", "Test that pwait returns before the " + "target process has been reaped"); +} +ATF_TC_BODY(pwait_normal, tc) +{ + pwait_reap_test(true); +} + +ATF_TC(pwait_reap); +ATF_TC_HEAD(pwait_reap, tc) +{ + atf_tc_set_md_var(tc, "descr", "Test that pwait -r does not return " + "until the target process has been reaped"); +} +ATF_TC_BODY(pwait_reap, tc) +{ + pwait_reap_test(true); +} + +ATF_TP_ADD_TCS(tp) +{ + ATF_TP_ADD_TC(tp, pwait_normal); + ATF_TP_ADD_TC(tp, pwait_reap); + return (atf_no_error()); +}