From nobody Mon Jul 27 17:33:34 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h85Kq2hBJz6nHVc for ; Mon, 27 Jul 2026 17:33:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h85Kq07L3z3KjB for ; Mon, 27 Jul 2026 17:33:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785173615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DaDxlvrCCkJ0+NTpKnbhu2yNg8E5r7o/B7USJjxsE9U=; b=KpTsKjI4R21QB/vQIrkTOGl/hPfwktxt7OBtfFMPvJOtZPQNWUo7PYS0Fst0otmESZ+H3t aWwhNLwRbn29dOAZxjuIDU42yigijIdC9qJ9QAkCpRYNhrm8mtggSmd0CGTvstxJ8emjea 2mBaMw2TkcpLZkyGyNXbnGhc+pXU3r5zzfZtIpPlS2EvUcgXP6OFfhQMHk33wKPC7qL/5Q cC/152L/Dxf/Fd2AVY/yvLIaW1ho4syVlLf7Zs2sKnIO6qUuNyinOuPthlXLol+kdJpPCG l0In1ZJoaDILGAL9kgTQecu+wvKkGk7NCHj0CMEA1x6KKgBTSKSA+jJtlKb/3g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785173615; a=rsa-sha256; cv=none; b=pm/9yAwZwtxra35VdlZCa8hXk2zarApuTOSlLjmbVYw5FFv2yRENas2CMDU8acOlyAMUZw ecHAYlAyukqoAG6RBdTaKG2zrDLnjm6dl8z7jANPi0abv0GIIiguRu4/h8SqQNHdRDhzXM WLkmj+jhR5PZUtEteE7EWmq6XK2sdDzArluOaOKdMMbrbKvNc9TZYEa5AWNGhMDemL8A3B YzHaKHqrXa5EP8F0CnVZeSc+7QZfVR8Yf36b7LBAhWyI20YqN9A9LJybFEqC6zsHLnQdKC mG2PbUq5pBRVns95M8+308AmNgunBFtLuFHnAKOzbMlYvm2EUwdeb61x2rl2Tw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785173615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DaDxlvrCCkJ0+NTpKnbhu2yNg8E5r7o/B7USJjxsE9U=; b=Y9jj8tgHezIsIH3BEW8+OWVW3F1Ols065Y9a5KelGmPzVnTtsU2BuBashkNC5zZkmmqhOT hWTdxBMLBk+WchVt6Ibp/2m2BbRra71DuqRsqAa8SLOKKiHPoqEUFVhcpppwfZK2k5026B a7pPIvRNPty0OdslCZ8JkS1MSCerBbH37TJQxuWEiQY2fRSQdyzuuRqsMMZIbSD+0mWQSs LqgIpbHTMOgyC0IoCIDzBpNzcXSqyaDIHoB00LUjI15zna+J7e2BA5/irFZ8eB+7WFJBVR zWkgCyWRsbHvREe0MRLNaO+/VfaOyRvnuy9T2Lx+PfgPJc8o9PLpA1k+OtUT2w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h85Kp6BTnz1Hj9 for ; Mon, 27 Jul 2026 17:33:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 25d26 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 27 Jul 2026 17:33:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 698e0c419895 - stable/15 - zvol: Fix uses of uninitialized variables in zvol_rename_minors_impl() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 698e0c419895da2d0d12c5f4d61d85a1d91b6b9d Auto-Submitted: auto-generated Date: Mon, 27 Jul 2026 17:33:34 +0000 Message-Id: <6a67966e.25d26.67a34039@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=698e0c419895da2d0d12c5f4d61d85a1d91b6b9d commit 698e0c419895da2d0d12c5f4d61d85a1d91b6b9d Author: Mark Johnston AuthorDate: 2026-02-12 22:10:36 +0000 Commit: Mark Johnston CommitDate: 2026-07-27 17:29:04 +0000 zvol: Fix uses of uninitialized variables in zvol_rename_minors_impl() Reported-by: GitHub Copilot Reviewed-by: Brian Behlendorf Reviewed-by: Alexander Motin Signed-off-by: Mark Johnston Closes #18191 (cherry picked from commit 943a05528494b2f4585541089606796476fb229e) --- sys/contrib/openzfs/module/zfs/zvol.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/contrib/openzfs/module/zfs/zvol.c b/sys/contrib/openzfs/module/zfs/zvol.c index 67ba68aca83d..e1fe3eae2f27 100644 --- a/sys/contrib/openzfs/module/zfs/zvol.c +++ b/sys/contrib/openzfs/module/zfs/zvol.c @@ -1778,6 +1778,7 @@ zvol_rename_minors_impl(zvol_task_t *task) if (zvol_inhibit_dev) return; + last_error = 0; oldnamelen = strlen(oldname); rw_enter(&zvol_state_lock, RW_WRITER); @@ -1797,6 +1798,8 @@ zvol_rename_minors_impl(zvol_task_t *task) zv->zv_name + oldnamelen + 1); error = zvol_os_rename_minor(zv, name); kmem_strfree(name); + } else { + error = 0; } if (error) { last_error = error;