From owner-p4-projects@FreeBSD.ORG Mon Sep 24 11:20:12 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 4592616A4BF; Mon, 24 Sep 2007 11:20:12 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1BF5B16A417; Mon, 24 Sep 2007 11:20:12 +0000 (UTC) (envelope-from ticso@cicely12.cicely.de) Received: from raven.bwct.de (raven.bwct.de [85.159.14.73]) by mx1.freebsd.org (Postfix) with ESMTP id 73CEC13C459; Mon, 24 Sep 2007 11:20:11 +0000 (UTC) (envelope-from ticso@cicely12.cicely.de) Received: from cicely5.cicely.de ([10.1.1.7]) by raven.bwct.de (8.13.4/8.13.4) with ESMTP id l8OAhPjV003876; Mon, 24 Sep 2007 12:43:26 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (cicely12.cicely.de [10.1.1.14]) by cicely5.cicely.de (8.13.4/8.13.4) with ESMTP id l8OAhLI7009396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 24 Sep 2007 12:43:21 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (localhost [127.0.0.1]) by cicely12.cicely.de (8.13.4/8.13.3) with ESMTP id l8OAhK4i042471; Mon, 24 Sep 2007 12:43:20 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: (from ticso@localhost) by cicely12.cicely.de (8.13.4/8.13.3/Submit) id l8OAhKsC042470; Mon, 24 Sep 2007 12:43:20 +0200 (CEST) (envelope-from ticso) Date: Mon, 24 Sep 2007 12:43:20 +0200 From: Bernd Walter To: Hans Petter Selasky Message-ID: <20070924104320.GE38890@cicely12.cicely.de> References: <200709231625.l8NGPhaR097038@repoman.freebsd.org> <46F6A3C3.6010408@FreeBSD.org> <200709232113.34718.hselasky@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200709232113.34718.hselasky@freebsd.org> X-Operating-System: FreeBSD cicely12.cicely.de 5.4-STABLE alpha User-Agent: Mutt/1.5.9i X-Spam-Status: No, score=-4.2 required=5.0 tests=ALL_TRUSTED=-1.8, AWL=0.172, BAYES_00=-2.599 autolearn=ham version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on cicely12.cicely.de Cc: Perforce Change Reviews , "Constantine A. Murenin" Subject: Re: PERFORCE change 126745 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: ticso@cicely.de List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2007 11:20:12 -0000 On Sun, Sep 23, 2007 at 09:13:33PM +0200, Hans Petter Selasky wrote: > Hi Constantine, > > Thanks for your input and I _know_ that my code is not 100% style compliant. > Most of the style misbehaves are probably there due to the way my "xemacs" > autoformatting behaves. And I love curly brackets and parenthesis, by the > way :-) > > My plan is to clean up all the style stuff by a small C-program in the end, > because doing it by hand is waste of my time. Probably it will take less time > to write that program than the actual manual edit when we are talking about > doing alot of edits. It wonders me if such a tool already exists, because the > code is technically OK. There is indent(1) in src, but it doesn't produce 100% style(9) clean code either. I usually use it as a starting point for very ugly formated code. I'm not shure it will make things easier in this special case, maybe just different. But very likely you can use it to automatically fix at least a few common points. Enhancing indent to produce style(9) code would be a great feature... -- B.Walter http://www.bwct.de http://www.fizon.de bernd@bwct.de info@bwct.de support@fizon.de