Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 31 Aug 2013 09:15:57 -0500
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r325807 - in head: . Mk
Message-ID:  <5221FA9D.7020005@FreeBSD.org>
In-Reply-To: <20130831141013.GA27765@FreeBSD.org>
References:  <201308311356.r7VDu8N8094811@svn.freebsd.org> <20130831141013.GA27765@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--XXoMtJ12k5ivo0XOrbO0O676OIph0kC3v
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 8/31/2013 9:10 AM, Alexey Dokuchaev wrote:
> On Sat, Aug 31, 2013 at 01:56:08PM +0000, Bryan Drewery wrote:
>> New Revision: 325807
>> URL: http://svnweb.freebsd.org/changeset/ports/325807
>>
>> - Add USE_PACKAGE_DEPENDS_ONLY which will try installing dependencies
>>   from existing packages and not fallback on building from source.
>>
>>   This is useful for package building tools such as poudriere and tind=
erbox
>>   to avoid building from source and confusing the build log, if a depe=
ndency
>>   failed to build for some reason.
>=20
> I actually don't quite see the use for any of them.  As for the build l=
og,
> if I understand correctly what you're describing, usually it's *good* t=
o
> "confuse" the log, as it's an indication of wrongly spelled _DEPENDS li=
ne.
>=20
> Am I missing some really warranted usage scenario for these knobs?
>=20
> ./danfe
>=20

make build-depends USE_PACKAGE_DEPENDS
  This installs dependencies from packages if present, else, fallback on
source.

make build-depends USE_PACKAGE_DEPENDS_ONLY
  This installs dependencies from packages only.

It has nothing to do with misspelling anything.

These are used to install dependencies from packages using the ports
framework. The alternative is to have the package building tool install
the dependencies themselves, which tinderbox _and_ portbuild do wrong!
Why reinvent the wheel. Let the ports framework install depenencies with
'build-depends', and use packages from already built.

The reason for _ONLY is that if a dependency failed to build, a port
would still, in some race-condition cases, run build-depends, not find
the dependency packages, then try to build them. Having no network
access, it would hit fetch errors; it shouldn't be building missing
dependencies, it should immediately fail because dependencies were not me=
t.

The PR has more information and linked patches which demonstrate the issu=
e:

http://www.bayofrum.net/~crees/scratch/log.log

With fix:

http://www.bayofrum.net/~crees/scratch/loglog.log

--=20
Regards,
Bryan Drewery


--XXoMtJ12k5ivo0XOrbO0O676OIph0kC3v
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSIfqeAAoJEG54KsA8mwz50zQP/RDA/zPFEKl1JnmsZXbh4bwG
6I4nsC1Bk0nKh9+GaiJpQ5AWXx4gp1uLGzW8hMWfl9mpk5jWgQ/YpFtZkGK3tV4K
NOOAzzlJnNTDjhCfUsTS6BXJHwVYe/Hre1RzDrYKhcoAhwEckzRLLDM1UJQud241
gLDRvwswByXKmcFXaZaAAII1y9VK188Z9iK1aAB+iwCOiMW0cxB6Qs8X709OPAVf
BWlGBsfTMQDxsowLn23vPXT6gI/VRnY163nAmiHXBjQ2JrLUgw0BVusDyNqvlril
DQdQvypTnQ7ahiOT5an30bErHCBbwkNPayVYx1+K7X0GPymY2QcAYR8pGPm4AJzL
1BsXQODNOVci9xC91C9G0753iqcx8LmxWhk6YBTB+LYaaVG3c5wvUrC4zw9y21VA
xZQ6qUzDRcK5kt3MJMn2KKKG10lIGcr4C+QY4cRQdU03vwpqLMNaBllhN8CMoUMw
B7EY3597LbHvUKIS69ODgi9zaIKqAE5VS2nYua/FyOIDW+IwVyJZ9yVbp5yIHqtt
FQuo4mlX2vPY2f/21bPmTcWw4Y+XMWDuuKHiqyNA3wD2U45GP0tQOgAE0nuHyJXZ
xuRUczIbzhqRBbjIYc2cTTzKkWocEjCcvhFv6shnAgPbyqxalm8QrOHGLGY2U9my
XeaRY+onpaztk4ITSkLK
=e5of
-----END PGP SIGNATURE-----

--XXoMtJ12k5ivo0XOrbO0O676OIph0kC3v--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5221FA9D.7020005>