From owner-freebsd-geom@FreeBSD.ORG  Wed Feb  5 17:18:45 2014
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A4AE934D;
 Wed,  5 Feb 2014 17:18:45 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 760A611DF;
 Wed,  5 Feb 2014 17:18:45 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s15HIjVR050451;
 Wed, 5 Feb 2014 17:18:45 GMT
 (envelope-from brueffer@freefall.freebsd.org)
Received: (from brueffer@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s15HIiMD050447;
 Wed, 5 Feb 2014 18:18:44 +0100 (CET) (envelope-from brueffer)
Date: Wed, 5 Feb 2014 18:18:44 +0100 (CET)
Message-Id: <201402051718.s15HIiMD050447@freefall.freebsd.org>
To: mattblists@icritical.com, brueffer@FreeBSD.org, freebsd-geom@FreeBSD.org
From: brueffer@FreeBSD.org
Subject: Re: kern/176744: [geom] [patch] BIO_FLUSH not recorded by devstats
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: GEOM-specific discussions and implementations
 <freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom/>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Feb 2014 17:18:45 -0000

Synopsis: [geom] [patch] BIO_FLUSH not recorded by devstats

State-Changed-From-To: open->feedback
State-Changed-By: brueffer
State-Changed-When: Wed Feb 5 18:11:49 CET 2014
State-Changed-Why: 
Hi Matt, I debated this change with mav@ and we were wondering what your specific
use for this change is.

While an adapted version (https://people.freebsd.org/~brueffer/geom_devstat.diff)
of this patch works, the upstream userland tools have no special handling for BIO_FLUSH
events.  They end up in the _OTHER categories of libdevstat(3), which e.g. gstat does not
show at all.

Could you elaborate?

http://www.freebsd.org/cgi/query-pr.cgi?pr=176744