Date: Thu, 13 Oct 2016 18:14:29 +0200 From: Julien Charbon <jch@freebsd.org> To: Slawa Olhovchenkov <slw@zxy.spb.ru> Cc: Konstantin Belousov <kostikbel@gmail.com>, freebsd-stable@FreeBSD.org, hiren panchasara <hiren@strugglingcoder.info> Subject: Re: 11.0 stuck on high network load Message-ID: <be331d47-dafc-10be-12dd-2b1bf9679a90@freebsd.org> In-Reply-To: <20161013151715.GL57714@zxy.spb.ru> References: <20161012095233.GC57714@zxy.spb.ru> <e4f1343c-636a-0970-856b-e65955f79e1a@freebsd.org> <20161012121322.GB57876@zxy.spb.ru> <62d8861c-673e-6d86-e96e-751399e505e5@freebsd.org> <20161012130103.GD57714@zxy.spb.ru> <e8a46471-576d-e074-8a50-5c316fb98bce@freebsd.org> <20161012154229.GC57876@zxy.spb.ru> <bc6810d8-af4c-1716-cbc7-e64819b78ccd@freebsd.org> <20161013143825.GK57714@zxy.spb.ru> <33ab0bfc-7009-95a7-7752-c2c439092e85@freebsd.org> <20161013151715.GL57714@zxy.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--77t2wdg15S3ivEXxVVQvo5c8JV1DO52u6
Content-Type: multipart/mixed; boundary="o2IrimuSsOFSk8pIWPSFxEP7aw5M0QFgs";
protected-headers="v1"
From: Julien Charbon <jch@freebsd.org>
To: Slawa Olhovchenkov <slw@zxy.spb.ru>
Cc: Konstantin Belousov <kostikbel@gmail.com>, freebsd-stable@FreeBSD.org,
hiren panchasara <hiren@strugglingcoder.info>
Message-ID: <be331d47-dafc-10be-12dd-2b1bf9679a90@freebsd.org>
Subject: Re: 11.0 stuck on high network load
References: <20161012095233.GC57714@zxy.spb.ru>
<e4f1343c-636a-0970-856b-e65955f79e1a@freebsd.org>
<20161012121322.GB57876@zxy.spb.ru>
<62d8861c-673e-6d86-e96e-751399e505e5@freebsd.org>
<20161012130103.GD57714@zxy.spb.ru>
<e8a46471-576d-e074-8a50-5c316fb98bce@freebsd.org>
<20161012154229.GC57876@zxy.spb.ru>
<bc6810d8-af4c-1716-cbc7-e64819b78ccd@freebsd.org>
<20161013143825.GK57714@zxy.spb.ru>
<33ab0bfc-7009-95a7-7752-c2c439092e85@freebsd.org>
<20161013151715.GL57714@zxy.spb.ru>
In-Reply-To: <20161013151715.GL57714@zxy.spb.ru>
--o2IrimuSsOFSk8pIWPSFxEP7aw5M0QFgs
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 10/13/16 5:17 PM, Slawa Olhovchenkov wrote:
> On Thu, Oct 13, 2016 at 05:06:00PM +0200, Julien Charbon wrote:
>=20
>>>> will give you that trace in the core, and without INVARIANT then it =
is
>>>> better to use dtrace:
>>>>
>>>> $ cat tcp-twstart-dropped.d
>>>> fbt::tcp_twstart:entry
>>>> /args[0]->t_inpcb->inp_flags & 0x04000000/
>>>> {
>>>> stack();
>>>> printf("INP_DROPPED in tcp_twstart: %x", args[0]->t_inpcb->inp_fla=
gs);
>>>> }
>>>
>>> Same code may be insert there too, IMHO.
>>
>> Hmm, I don't think so:
>>
>> - If you have INVARIANT, the kernel will panic in tcp_twstart() or
>> tcp_detach() and you will have everything you need to debug.
>> - If you don't, dtrace is the right tool to use in all cases anyway.
>=20
> dtrace don't executed in may case w/ diagnostic "dtrace: processing
> aborted: Abort due to systemic unresponsiveness". This is for
> tcp_close. May be tcp_twstart will be more successuful, may be not.
It does and will.
> Also, using dtrace too complex in production (need complex startup
> under screen and capture output) and for many peoples.
> kdb_backtrace() have too less administrative overhead.
I still think it is overkill. The main goal of this change is to fix a
quite tricky and old TCP stack locking issue. Let's try to do that
first, it is complex enough by itself.
Once the fix is validated and pushed, feel free to propose your own
patch/review to add kdb_backtrace(), log(), etc.. to get other devs
point of view.
I don't remember who said: "Never ever optimize error cases"...
--
Julien
--o2IrimuSsOFSk8pIWPSFxEP7aw5M0QFgs--
--77t2wdg15S3ivEXxVVQvo5c8JV1DO52u6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQEcBAEBCgAGBQJX/7LtAAoJEKVlQ5Je6dhxl0gH/1exUJnXktv5wXl3Pt9u41Sq
stw7JS2C3l1TSk5m1cIw9U2vfD0Ok7iY/ksmXEnNtUlOB3MLF5Z954AVdghUtBt2
D7gGpcTYbxyiU8MxKsT6I4UO0aEQoQBkJqPDLQUMpS3QLc73tYzypkj8PO7ype6m
HsY4ONga5GlP/WoeKovHmAxocXL8mgz+xYAbuovqtgy6yEhc1w6bRI9/u/5lONQb
tjiOcgwZAB+erJqNXoZ/8WllgbwJ/ujBl3XzLXqMEvy82infmZ+luvaCkAACbbJV
OWTeqiA8PW6+6MxGnhkaGu8iSf2X0tGLsfDck0ny9TZkO4xwEfxvIaszqMxj6Jw=
=g/dO
-----END PGP SIGNATURE-----
--77t2wdg15S3ivEXxVVQvo5c8JV1DO52u6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?be331d47-dafc-10be-12dd-2b1bf9679a90>