From owner-freebsd-usb@FreeBSD.ORG Mon Nov 15 00:08:20 2004 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1638016A4CE for ; Mon, 15 Nov 2004 00:08:20 +0000 (GMT) Received: from mta09-winn.mailhost.ntl.com (mailhost.ntl.com [212.250.162.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F66943D41 for ; Mon, 15 Nov 2004 00:08:19 +0000 (GMT) (envelope-from scott@fishballoon.org) Received: from aamta01-winn.mailhost.ntl.com ([212.250.162.8]) by mta09-winn.mailhost.ntl.com with ESMTP <20041115000818.TEFZ1968.mta09-winn.mailhost.ntl.com@aamta01-winn.mailhost.ntl.com> for ; Mon, 15 Nov 2004 00:08:18 +0000 Received: from llama.fishballoon.org ([82.4.146.133]) by aamta01-winn.mailhost.ntl.com with ESMTP <20041115000818.SKXI17601.aamta01-winn.mailhost.ntl.com@llama.fishballoon.org> for ; Mon, 15 Nov 2004 00:08:18 +0000 Received: from tuatara.fishballoon.org ([192.168.1.6]) by llama.fishballoon.org with esmtp (Exim 4.43 (FreeBSD)) id 1CTUPo-000P2B-5A for freebsd-usb@freebsd.org; Mon, 15 Nov 2004 00:08:16 +0000 Received: (from scott@localhost) by tuatara.fishballoon.org (8.13.1/8.13.1/Submit) id iAF08FtB008799 for freebsd-usb@freebsd.org; Mon, 15 Nov 2004 00:08:15 GMT (envelope-from scott) Date: Mon, 15 Nov 2004 00:08:15 +0000 From: Scott Mitchell To: freebsd-usb@freebsd.org Message-ID: <20041115000815.GD57138@tuatara.fishballoon.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 4.10-STABLE i386 Subject: USB Ethernet (aue) panics on 4.10 (kern/69319) X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2004 00:08:20 -0000 Hi all, Is anyone else using USB Ethernet - particularly anything that uses the aue(4) driver - on FreeBSD 4.10, with or without success? I have a reproducible panic when aue(4) devices are first brought up, ie. on the first ifconfig(8) of the device, with two different adapters on two different 4.10/4-STABLE systems. See PR kern/69319 for more details: http://www.freebsd.org/cgi/query-pr.cgi?pr=69319 Anyone else seeing this or am I the only one using these devices on 4.10? I discussed this a bit with Julian and others a few weeks ago, until the 5.3 release got in the way. It seems to be related to the removal of the 'tsleep hack' from the 4-STABLE USB code, although I don't know this stuff well enough to say exactly why it's breaking. Certainly restoring the tsleep hack makes my aue(4) adapters work again. The attached patch restores the tsleep hack and fixes a couple of other problems I found while looking into this: - Fix an mbuf leak when the [ackr]_start() function was called again before the previous mbuf had been freed. - Fix ioctl handling to return EINVAL for commands that don't make sense for this device. Otherwise ifconfig(8) prints a lot of irrelevant data, such as wireless settings. With this patch in place both of my adapters work just fine. I'm tempted to just commit this patch to get everything working again, but I know people will be upset about the return of the tsleep hack. It is a hack, but one that we had in the tree for several years, so clearly not causing anybody too much pain. I'd love to find out what's really wrong and fix it, but I have neither the USB know-how nor the free time to acquire it right now. So, any of the USB gurus out there who'd like to help me fix this? I know it's only 4.x, but it would be nice if we could retire it in a working state... :-) Cheers, Scott -- =========================================================================== Scott Mitchell | PGP Key ID | "Eagles may soar, but weasels Cambridge, England | 0x54B171B9 | don't get sucked into jet engines" scott at fishballoon.org | 0xAA775B8B | -- Anon