From owner-svn-src-all@FreeBSD.ORG Mon Dec 7 11:27:29 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F8201065670; Mon, 7 Dec 2009 11:27:29 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: from mail-yw0-f194.google.com (mail-yw0-f194.google.com [209.85.211.194]) by mx1.freebsd.org (Postfix) with ESMTP id 2139E8FC0A; Mon, 7 Dec 2009 11:27:28 +0000 (UTC) Received: by ywh32 with SMTP id 32so4532771ywh.14 for ; Mon, 07 Dec 2009 03:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:from:date:x-google-sender-auth:message-id:subject:to:cc :content-type; bh=2VaDQgvh51pefpO5lhrhYjrA00dPPSNbrvCNEZLWDJo=; b=Ek1kmE9BtoXOdlhRdHj6+aOy4C5JdQMQzSrCuAHz7ZFceSbgjel3O4zC6tw+xhi4R9 aA0I9HcfYJbCuCx+58FCtKd+bucczaBI0NlbZrl3FWbXocO/vEjrBsM3jDaqNmYmgL5G za/ziFdyTObnbW91o4iPJsZLvFq/D7XXTY7ac= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; b=Jw9ZQvJOYj8qy7XSQ9vslXPqRDBqXJJRa3fmdudhwG9IPhyjqwOcnsugd/k9JWlxZv plA2gHc9yGkiI4NNEHoH32/ckVoPGFtAwZF20PedhdLw7pcaTaPm9OQqL0Gh6XaM5hAu A3NR/rFZ4Ia2LjZ5O3wv8myxJo96LH/ZhPZ4U= MIME-Version: 1.0 Sender: ermal.luci@gmail.com Received: by 10.150.75.6 with SMTP id x6mr11015469yba.283.1260183725081; Mon, 07 Dec 2009 03:02:05 -0800 (PST) In-Reply-To: <200912070531.17758.max@love2party.net> References: <200912061804.nB6I4R38027652@svn.freebsd.org> <200912070531.17758.max@love2party.net> From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= Date: Mon, 7 Dec 2009 12:01:45 +0100 X-Google-Sender-Auth: c3a8847b13729a5a Message-ID: <9a542da30912070301x4ada4d0ct67ec8553a477aea2@mail.gmail.com> To: Max Laier Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@freebsd.org, Luigi Rizzo , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r200183 - head/sbin/ipfw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2009 11:27:29 -0000 On Mon, Dec 7, 2009 at 5:31 AM, Max Laier wrote: > On Sunday 06 December 2009 19:04:27 Luigi Rizzo wrote: > > Author: luigi > > Date: Sun Dec 6 18:04:26 2009 > > New Revision: 200183 > > URL: http://svn.freebsd.org/changeset/base/200183 > > > > Log: > > restore setting of sin_len (was removed in 1.146 last february) as > > it seems that now it is necessary for 'forward' to work outside lo0. > > The bug (and fix) was reported on 8.0. This patch probably applies > > to RELENG_7 as well. > > It seems that 'pf' has a similar bug. > > > > Submitted by: Lytochkin Boris > > Do you have a reference for me? > I followed the thread but route-to sets the sin_len see this: http://fxr.watson.org/fxr/source/contrib/pf/net/pf.c?v=FREEBSD8#L6179 > > > MFC after: 3 days > > > > Modified: > > head/sbin/ipfw/ipfw2.c > > > > Modified: head/sbin/ipfw/ipfw2.c > > > =========================================================================== > > === --- head/sbin/ipfw/ipfw2.c Sun Dec 6 17:26:43 2009 > (r200182) > > +++ head/sbin/ipfw/ipfw2.c Sun Dec 6 18:04:26 2009 (r200183) > > @@ -2740,9 +2740,11 @@ chkarg: > > > > /* > > * In the kernel we assume AF_INET and use only > > - * sin_port and sin_addr. > > + * sin_port and sin_addr. Remember to set sin_len as > > + * the routing code seems to use it too. > > */ > > p->sa.sin_family = AF_INET; > > + p->sa.sin_len = sizeof(struct sockaddr_in); > > p->sa.sin_port = 0; > > /* > > * locate the address-port separator (':' or ',') > > > > > > !DSPAM:4b1bf5b9894172410716004! > > > -- Ermal