From owner-cvs-src@FreeBSD.ORG Wed Dec 6 15:46:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3FD5316A412; Wed, 6 Dec 2006 15:46:08 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4718D43CBA; Wed, 6 Dec 2006 15:45:17 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id kB6Fk00R073219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Dec 2006 18:46:01 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id kB6FjtIs073218; Wed, 6 Dec 2006 18:45:55 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 6 Dec 2006 18:45:55 +0300 From: Gleb Smirnoff To: Bruce Evans Message-ID: <20061206154555.GM32700@FreeBSD.org> References: <200612060218.kB62IfVn046324@repoman.freebsd.org> <20061206164242.A32496@delplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20061206164242.A32496@delplex.bde.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, Marius Strobl , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c if_xlreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2006 15:46:08 -0000 On Wed, Dec 06, 2006 at 06:01:48PM +1100, Bruce Evans wrote: B> It's a shame to force all NIC drivers to manage the timeout for this. B> Most have a timeout for other purposes so I couldn't see how to save B> much code using a callback, but a callback would be cleaner. (To avoid B> the race, just move the decrement of the count to drivers.) It is a shame to have a two extra fields in struct ifnet, just for the sake of the drivers that can wedge. It is a shame to go through the whole list of interfaces every second. There are routers with few NICs and dozens of vlan(4) interfaces. There are also PPP concentrators with up to thousand interfaces and only one NIC that really needs to have its watchdog. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE