Date: Sat, 08 Jun 2013 07:47:46 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: eadler@FreeBSD.org Cc: wblock@wonkity.com, trhodes@FreeBSD.org, svn-doc-head@FreeBSD.org, gjb@FreeBSD.org, svn-doc-all@FreeBSD.org, doc-committers@FreeBSD.org Subject: Re: svn commit: r41848 - head/en_US.ISO8859-1/htdocs/layout/js Message-ID: <20130608.074746.878470589090500805.hrs@allbsd.org> In-Reply-To: <CAF6rxgnxjDn_sjviCSZVpMDs40OYZS6D6MrKzs0YZvm2sC-qdg@mail.gmail.com> References: <20130607.092534.356568932887378565.hrs@allbsd.org> <20130607113436.4dc1cbc3.trhodes@FreeBSD.org> <CAF6rxgnxjDn_sjviCSZVpMDs40OYZS6D6MrKzs0YZvm2sC-qdg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Sat_Jun__8_07_47_46_2013_424)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Eitan Adler <eadler@freebsd.org> wrote in <CAF6rxgnxjDn_sjviCSZVpMDs40OYZS6D6MrKzs0YZvm2sC-qdg@mail.gmail.com>: ea> On 7 June 2013 17:34, Tom Rhodes <trhodes@freebsd.org> wrote: ea> > On Fri, 07 Jun 2013 09:25:34 +0900 (JST) ea> > Hiroki Sato <hrs@FreeBSD.org> wrote: ea> > ea> >> Eitan Adler <eadler@freebsd.org> wrote ea> >> in <CAF6rxg=tnyCyLP50RpO8j20jbnGO_Mycb7aq5P3pRVz9NtvokA@mail.gmail.com>: ea> >> ea> >> ea> On 6 June 2013 16:28, Hiroki Sato <hrs@freebsd.org> wrote: ea> >> ea> > ea> >> ea> > null, "", and undefined are evaluated as false in Javascript. ea> >> ea> > ea> >> ea> Javascript has an odd concept of true and false: ea> >> ea> null, an empty string, +0, -0, and NaN, and false are the 'false' values. ea> >> ea> ea> >> ea> An object will return true. ea> >> ea> >> I see. I am not familiar with DNT implementation, but is there a www ea> >> browser to define navigator.doNotTrack as the value "false"? ea> >> ea> >> If so, I think something like the following is needed. ea> >> ea> >> var dnt = window.navigator.msDoNotTrack || window.navigator.doNotTrack; ea> >> var allow_track = (dnt && dnt == 'yes'|| dnt == 1); ea> >> ea> >> -- Hiroki ea> >> ea> > ea> > I was assuming based on the discussion that we need to perform ea> > more than a single check on this, but will this one actually ea> > work? ea> ea> No, after some thoughts I realized that this commit is completely ea> broken. We must explicitly check for "yes" and "1". This check ea> basically disabled GA for newer browsers. The above code should perform it. What is "this check" in your sentence? -- Hiroki ----Security_Multipart(Sat_Jun__8_07_47_46_2013_424)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlGyYxIACgkQTyzT2CeTzy0ypQCeNRvwGF8gm7x4v50JKE2kEX+c C50AoIxbSYYltjwy65rmPfEWcYDuZSO0 =C83a -----END PGP SIGNATURE----- ----Security_Multipart(Sat_Jun__8_07_47_46_2013_424)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130608.074746.878470589090500805.hrs>