From owner-cvs-all Sun Mar 4 17:30:28 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 4E40637B719; Sun, 4 Mar 2001 17:30:24 -0800 (PST) (envelope-from alc@FreeBSD.org) Received: (from alc@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f251UOr88061; Sun, 4 Mar 2001 17:30:24 -0800 (PST) (envelope-from alc) Message-Id: <200103050130.f251UOr88061@freefall.freebsd.org> From: Alan Cox Date: Sun, 4 Mar 2001 17:30:24 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern vfs_aio.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG alc 2001/03/04 17:30:24 PST Modified files: sys/kern vfs_aio.c Log: Eliminate the aio_freejobs list. Its purpose was to store free aiocb's allocated by zalloc(). In other words, zfree() was never called. Now, we call zfree(). Why eliminate this micro- optimization? At some later point, when we multithread the AIO system, we would need a mutex to synchronize access to aio_freejobs, making its use nearly indistinguishable in cost from zalloc() and zfree(). Remove unnecessary fhold() and fdrop() calls from aio_qphysio(), undo'ing a part of revision 1.86. The reference count on the file structure is already incremented by _aio_aqueue() before it calls aio_qphysio(). (Update the comments to document this fact.) Remove unnecessary casts from _aio_aqueue(), aio_read(), aio_write() and aio_waitcomplete(). Remove an unnecessary "return;" from aio_process(). Add "static" in various places. Revision Changes Path 1.93 +31 -41 src/sys/kern/vfs_aio.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message