From owner-svn-src-head@FreeBSD.ORG Mon Oct 27 16:03:19 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E5D510656DC for ; Mon, 27 Oct 2008 16:03:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 83F988FC1D for ; Mon, 27 Oct 2008 16:03:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id m9RG2Y1e012952; Mon, 27 Oct 2008 12:03:10 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Warner Losh Date: Mon, 27 Oct 2008 11:59:31 -0400 User-Agent: KMail/1.9.7 References: <868wsewzos.fsf@ds4.des.no> <200810241031.08780.jhb@freebsd.org> <20081024.164740.74747369.imp@bsdimp.com> In-Reply-To: <20081024.164740.74747369.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810271159.31843.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Mon, 27 Oct 2008 12:03:11 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8508/Mon Oct 27 09:02:44 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: danfe@freebsd.org, marcel@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org, des@des.no Subject: Re: svn commit: r184193 - in head/sys: arm/conf conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Oct 2008 16:03:19 -0000 On Friday 24 October 2008 06:47:40 pm Warner Losh wrote: > From: John Baldwin > Subject: Re: svn commit: r184193 - in head/sys: arm/conf conf > Date: Fri, 24 Oct 2008 10:31:07 -0400 > > > On Friday 24 October 2008 09:27:03 am Alexey Dokuchaev wrote: > > > On Fri, Oct 24, 2008 at 03:26:43AM +0200, Dag-Erling Sm??rgrav wrote: > > > > Warner Losh writes: > > > > > We already have a better mechanism for including config files. We > > > > > should be using that instead of poluting another port with the > > > > > DEFAULTS file. > > > > > > > > Should we even have DEFAULTS files at all? IMHO they just confuse > > > > matters by introducing "stealth" options into your config. > > > > > > I tend to second this. I always try to get everything possible out of > > > my kernel to modules, and thus was surprised to see io.ko and mem.ko > > > fail to load because they were silently included into my custom kernel. > > > > > > I understand that some things like 'device isa' and > > > 'device npx' aren't really optional, but if something is useful to have, > > > but can be loaded as a module, it belongs to GENERIC rather than > > > DEFAULTS. Killing the latter altogether and throwing a comment that > > > says particular option or device is mandatory in GENERIC is probably > > > even better (and more transparent). > > > > The one thing I think DEFAULTS is useful for are replacing NO_FOO options with > > FOO options. That is, if someone wants to turn a feature on by default, I'd > > rather them put 'options FOO' in DEFAULTS rather than rename all the > > #ifdef's,e tc. to '#ifndef NO_FOO'. > > Wouldn't it be better to move to a system where we explicitly include > std.i386 and have them all defined there? We already encourage stuff > like this with advice to include GENERIC with nodev... I wouldn't mind a std.i386, and if we make config's include keyword fall back to 'sys/conf' for relative path name lookups if the lookup in '.' fails then you can even put those files in sys/conf with the still-clean syntax of 'include std.i386'. However, I don't know about you, but I _never_ build a config by including GENERIC and then weeding stuff out. Too much stuff to weed out. Once I have a customized config for a machine I then include that in development branches to install kernels to different directories under /boot, etc. -- John Baldwin