From nobody Wed Nov 23 21:03:18 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NHYWv6R5nz4jJsc for ; Wed, 23 Nov 2022 21:03:55 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NHYWv5tQkz3xZP for ; Wed, 23 Nov 2022 21:03:55 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669237435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jo//H1VoOypwiiKT4h5QwwEipTRP7k75Xj+4/Ey9ba0=; b=rxCnhNbm4AWuKcoZg4DNt2nVQeW3smMGqY5nwzckAUPzA8aEVASrAaziWPDZlYmvPSiXku MbvQgn4kKfC7HtXJKMK/IcjieOOWak2w7hwRa6Q4KxrHKzfNQkQbVFED77oWPlGlHyhy6K LEO+xMfuRPmvSXj6vgvZvdk1ktRZJK60EGs/7BY8h1OyyN05USl3qKHirLOysNHR9Rnooj yzJmDGBb1TSCBKDqKNuDegLaW6RNTgaWVkdtQVlXAeojCLvsihPGSqYMLX9RHR7C6gBgbN rt5MgrOr2ClWzU0gm+q2rqXUBzVyKysdZ1cm1F0DsCrv+vqZKTVuHGaQdb1GdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669237435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jo//H1VoOypwiiKT4h5QwwEipTRP7k75Xj+4/Ey9ba0=; b=vUHRAbQll4mDfaKXmBdgCg8eJozJuwArdJeJ+V+Jn+iz5k9A6YLHSeeH+mpCAJQkylLpUF g0jbkcRa2D2dsbAvuTqfklKvlkOOZrUUcXVPxeOOhNKatBp/UaSxcDzFzMFRQRr+z5PcNA aFwuaiF/Id6hqNyz2NzuN6vZlezuSE6daKBC3xEk5hF6hhuX6Xy04vTjp6pIyGJ0R0ZktL OH1ZJLcO6iB8vFU9LUeO6fR87Zygv83SzQNwuQ0OJMEq01TWyChTAbAtzf50zOFejW3pmw QG38AgVVL5oAh6hjoEwZsNYhljt8XDpabzx5QHw0IuECfXPlfcXK6W4ixa0LWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669237435; a=rsa-sha256; cv=none; b=pJc6tT61KgdCNvMofkRNQeAxFP46Z9aKGnYeSNxAas7Do9UU8wfRAhAbUmuWWNZyWiijUs mdKIi8OsuAblXivbqrMjBf/GaVAi14Z1pRwkkCirC9pJWuysZmqRvKf59TXLhh8WG9iUE5 URor10LAgL0Ey5u4TDwnBm+lgyKTpRLRa7jV0b4PcIi18irlt852/AJTYrXqQ9LMIaAqU+ 4KqJGAhJZ9UNwrCxzL2MXECfjAoNDwNuITIKpHmsPw2BQdDsrGYInFHa3pdxDXAO0+QsJp s0sIvfDc+bzE2ayFHD29lfrSLVosSEjD4WlzDhGN+qgDXhbpQ/wWPSTt3nA0yg== Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NHYWv4flrz12Dx for ; Wed, 23 Nov 2022 21:03:55 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-pl1-f179.google.com with SMTP id 4so17759178pli.0 for ; Wed, 23 Nov 2022 13:03:55 -0800 (PST) X-Gm-Message-State: ANoB5pn3Xp8GhcKk/i5ywpsfZniO3M7BIw0NnzyroH/cmQhZx8iZLDRG QOlACCOEGavajyzgMAMzSLypGnn4SkF/42nkdY/luQ== X-Google-Smtp-Source: AA0mqf6f7uGV0Xyxrz4op+uHxZDRU75ESW7V+IdfuhOf8VSVauDScbzwksbwi/QpMVG/eOS9cLdObGf3odCKOyCanq4= X-Received: by 2002:a17:902:ab59:b0:188:dcfb:5993 with SMTP id ij25-20020a170902ab5900b00188dcfb5993mr10865078plb.172.1669237434447; Wed, 23 Nov 2022 13:03:54 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202211071228.2A7CSOpv081761@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Thu, 24 Nov 2022 05:03:18 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: aa1913df7f3f - main - devel/py-responses: switch to USES=pytest To: Dmitry Marakasov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000545f6d05ee29a020" X-ThisMailContainsUnwantedMimeParts: N --000000000000545f6d05ee29a020 Content-Type: text/plain; charset="UTF-8" On Mon, Nov 21, 2022 at 9:58 PM Dmitry Marakasov wrote: > * Po-Chuan Hsieh (sunpoet@freebsd.org) wrote: > > On Mon, Nov 7, 2022 at 8:28 PM Dmitry Marakasov > wrote: > > > > The branch main has been updated by amdmi3: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id= > > aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4 > > > > commit aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4 > > Author: Dmitry Marakasov > > AuthorDate: 2022-11-07 12:14:58 +0000 > > Commit: Dmitry Marakasov > > CommitDate: 2022-11-07 12:27:46 +0000 > > > > devel/py-responses: switch to USES=pytest > > > > > > Please stop doing this. > > It should be USE_PYTHON=pytest, not USES=pytest. > > Furthermore, all existing USES=pytest should be changed to > USE_PYTHON=pytest. > > Sorry, but you can't just tell me to stop using the framework I've > introduced, without at least notifying me beforehand of that there's > now a duplicate framework which is now preferred. > In fact unfortunately I will not stop unless all the ports are > converted to USE_PYTHON=pytest and USES=pytest removed (which you > should've done in the first place to save everybodys time and avoid > ambiguity) as I have a lot of pending commits with migration to > USES=pytest I don't feel like redoing unless I have to. > > Thank you for your work anyway, this looks more flexible whan > USES=pytest. > Sorry for not reminding you earlier. I've submitted a review [1] of the earlier version to you, therefore I guess you're aware of this change. Months later, I committed the updated version which adds support for more test frameworks. Anyway, thank you for converting your ports to USE_PYTHON=pytest. Please feel free to enhance the pytest support in Mk/Uses/python.mk. [1] https://reviews.freebsd.org/D35069 > -- > Dmitry Marakasov . > amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru/ > > --000000000000545f6d05ee29a020 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Nov 21, 2022 at 9:58 PM Dmitry Ma= rakasov <amdmi3@am= dmi3.ru> wrote:
* Po-Chuan Hsieh (sunpoet@freebsd.org) wrote:
> On Mon, Nov 7, 2022 at 8:28 PM Dmitry Marakasov <amdmi3@freebsd.org> wrote:
>
>=C2=A0 =C2=A0 =C2=A0The branch main has been updated by amdmi3:
>
>=C2=A0 =C2=A0 =C2=A0URL: https://cgit.FreeBSD.org/po= rts/commit/?id=3D
>=C2=A0 =C2=A0 =C2=A0aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4
>
>=C2=A0 =C2=A0 =C2=A0commit aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4
>=C2=A0 =C2=A0 =C2=A0Author:=C2=A0 =C2=A0 =C2=A0Dmitry Marakasov <amd= mi3@FreeBSD.org>
>=C2=A0 =C2=A0 =C2=A0AuthorDate: 2022-11-07 12:14:58 +0000
>=C2=A0 =C2=A0 =C2=A0Commit:=C2=A0 =C2=A0 =C2=A0Dmitry Marakasov <amd= mi3@FreeBSD.org>
>=C2=A0 =C2=A0 =C2=A0CommitDate: 2022-11-07 12:27:46 +0000
>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 devel/py-responses: switch to USES=3D= pytest
>
>
> Please stop doing this.
> It should be USE_PYTHON=3Dpytest, not USES=3Dpytest.
> Furthermore, all existing USES=3Dpytest should be changed to USE_PYTHO= N=3Dpytest.

Sorry, but you can't just tell me to stop using the framework I've<= br> introduced, without at least notifying me beforehand of that there's now a duplicate framework which is now preferred.

In fact unfortunately I will not stop unless all the ports are
converted to USE_PYTHON=3Dpytest and USES=3Dpytest removed (which you
should've done in the first place to save everybodys time and avoid
ambiguity) as I have a lot of pending commits with migration to
USES=3Dpytest I don't feel like redoing unless I have to.

Thank you for your work anyway, this looks more flexible whan
USES=3Dpytest.

Sorry for=C2=A0not = reminding you=C2=A0earlier. I've submitted a review [1] of the earlier = version to you, therefore I guess you're aware of this change.
Months later, I committed the updated version which adds=C2=A0support for= =C2=A0more test=C2=A0frameworks.

Anyway, thank= you for converting your ports to USE_PYTHON=3Dpytest.
Please fee= l free to enhance the pytest support in Mk/Uses/python.mk.

=C2=A0
--
Dmitry Marakasov=C2=A0 =C2=A0.
amdmi3@amdmi3.ru= =C2=A0 ..:=C2=A0 https://github.com/AMDmi3=C2=A0 https://amdmi3.ru/

--000000000000545f6d05ee29a020--