From owner-freebsd-current  Fri Dec 19 19:27:50 1997
Return-Path: <owner-freebsd-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id TAA14515
          for current-outgoing; Fri, 19 Dec 1997 19:27:50 -0800 (PST)
          (envelope-from owner-freebsd-current)
Received: from freebie.lemis.com (gregl1.lnk.telstra.net [139.130.136.133])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id TAA14508;
          Fri, 19 Dec 1997 19:27:33 -0800 (PST)
          (envelope-from grog@lemis.com)
Received: (from grog@localhost)
          by freebie.lemis.com (8.8.8/8.8.7) id NAA07467;
          Sat, 20 Dec 1997 13:57:17 +1030 (CST)
          (envelope-from grog)
Message-ID: <19971220135716.14528@lemis.com>
Date: Sat, 20 Dec 1997 13:57:16 +1030
From: Greg Lehey <grog@lemis.com>
To: Julian Elischer <julian@whistle.com>
Cc: Bruce Evans <bde@FreeBSD.ORG>, current@FreeBSD.ORG
Subject: Re: Bruce vandalism again
References: <199712200007.QAA04713@freefall.freebsd.org> <349B1196.167EB0E7@whistle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.88e
In-Reply-To: <349B1196.167EB0E7@whistle.com>; from Julian Elischer on Fri, Dec 19, 1997 at 04:30:14PM -0800
Organisation: LEMIS, PO Box 460, Echunga SA 5153, Australia
Phone: +61-8-8388-8286
Fax: +61-8-8388-8725
Mobile: +61-41-739-7062
WWW-Home-Page: http://www.lemis.com/~grog
Sender: owner-freebsd-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Fri, Dec 19, 1997 at 04:30:14PM -0800, Julian Elischer wrote:
> Bruce Evans wrote:
> > 
> > bde         1997/12/19 16:07:12 PST
> > 
> >   Modified files:
> >     sys/net              if_ethersubr.c
> >     sys/netinet          if_ether.c
> >   Log:
> >   Fixed gratuitous ANSIisms.
> > 
> >   Revision  Changes    Path
> >   1.41      +5 -2      src/sys/net/if_ethersubr.c
> >   1.42      +2 -2      src/sys/netinet/if_ether.c
> Bruce.
> 
> I know this has been discussed before,
> but I'm not convinced  that you are mving with the agreement of
> everybody here.
> 
>  int
> -ether_ioctl(struct ifnet *ifp, int command, caddr_t data)
> +ether_ioctl(ifp, command, data)
> +       struct ifnet *ifp;
> +       int command;
> +       caddr_t data;
>  {
>         struct ifaddr *ifa = (struct ifaddr *) data;
> 
> I know I am converting every function I add and anything I massively
> rewrite to use prototypes.
> I know I have a lot of people on my side here.
> a commit that does nothing but this vandalism is REALLY ANNOYING!

I agree.  This appears to be a seriously retrograde step.  Bruce, why?

Greg