From owner-svn-ports-head@FreeBSD.ORG Sat Apr 27 04:37:09 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id EAF9AC09 for ; Sat, 27 Apr 2013 04:37:09 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-la0-x235.google.com (mail-la0-x235.google.com [IPv6:2a00:1450:4010:c03::235]) by mx1.freebsd.org (Postfix) with ESMTP id 7191B1DC3 for ; Sat, 27 Apr 2013 04:37:09 +0000 (UTC) Received: by mail-la0-f53.google.com with SMTP id eg20so4058827lab.26 for ; Fri, 26 Apr 2013 21:37:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=7aH4/037DdwY1/ivyXqU/zkdeE7y9HxYpRC5s37rWaA=; b=Q6J910Mk869xOYM2MnhOJFJOoFkSyqgP614zA5paIqWuwTuxWiqfesBbGkOI+KXBJY E4t+CoeymOo+ckUu3uGRJUtiGrUoT5GQ3UE/X0I7Fqzb3Y+2Ee/q3JRKbxoNKjn5oAJN B8o/E38mqwghpviYtLrPli/kZ5gH7MCZY0jZmQMu4LwriT7AT1iV55tPsl7rIuuAOR+v EOFFr5KzAovm5AibWaonpo/6QRd7ktwOpY1mrnIapUBt0VFN4zWgYCqzKe5Uhgw3ko74 t/OrtlRXW/M2xNQ5vpUGR6BVv2fNC68ayej2KKL68pzjDdjh/vdcf6bJGlC4AdXGmKyf C5mw== X-Received: by 10.152.87.39 with SMTP id u7mr3297240laz.48.1367037427670; Fri, 26 Apr 2013 21:37:07 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.129.194 with HTTP; Fri, 26 Apr 2013 21:36:47 -0700 (PDT) In-Reply-To: <20130426201532.GE74139@ithaqua.etoilebsd.net> References: <201304222213.r3MMDFec026886@svn.freebsd.org> <20130426201532.GE74139@ithaqua.etoilebsd.net> From: Sunpoet Po-Chuan Hsieh Date: Sat, 27 Apr 2013 12:36:47 +0800 X-Google-Sender-Auth: lbbhhrKhRGr9PXOevSyh1DpmuCU Message-ID: Subject: Re: svn commit: r316281 - head/Mk To: Baptiste Daroussin X-Gm-Message-State: ALoCoQnvrVokhK6/QLULe0Fhz341/GUrG42c4/5d7J7V5sf7AeFfw60+U+DpsiQw1H2c7l9z0CZm Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Apr 2013 04:37:10 -0000 On Sat, Apr 27, 2013 at 4:15 AM, Baptiste Daroussin wrote: > On Sat, Apr 27, 2013 at 03:48:01AM +0800, Sunpoet Po-Chuan Hsieh wrote: > > On Tue, Apr 23, 2013 at 6:13 AM, Baptiste Daroussin >wrote: > > > > > Author: bapt > > > Date: Mon Apr 22 22:13:14 2013 > > > New Revision: 316281 > > > URL: http://svnweb.freebsd.org/changeset/ports/316281 > > > > > > Log: > > > Remove old links while creating the new packages > > > Force creation of the symlink for pkgng to avoid failure if the link > > > already exists > > > > > > Submitted by: ohauer@ > > > > > > Modified: > > > head/Mk/bsd.pkgng.mk > > > > > > Modified: head/Mk/bsd.pkgng.mk > > > > > > > ============================================================================== > > > --- head/Mk/bsd.pkgng.mk Mon Apr 22 22:06:34 2013 > (r316280) > > > +++ head/Mk/bsd.pkgng.mk Mon Apr 22 22:13:14 2013 > (r316281) > > > @@ -258,6 +258,9 @@ do-package: ${TMPPLIST} > > > fi; \ > > > fi; \ > > > fi; > > > + @for cat in ${CATEGORIES}; do \ > > > + ${RM} -fv > > > ${PACKAGES}/$$cat/${PKGNAMEPREFIX}${PORTNAME}*${PKG_SUFX} ; \ > > > + done > > > > > > > Please revert/modify this change! > > It has 2 problems. > > > > First, it would remove other *correct* links. > > > > % cd /usr/ports/x11/xorg > > % make package > > ... > > ===> Checking if x11/xorg already installed > > ===> Registering installation for xorg-7.5.2 > > Installing xorg-7.5.2... done > > ===> Building package for xorg-7.5.2 > > /usr/ports/packages/x11/xorg-7.5.2.txz > > /usr/ports/packages/x11/xorg-cf-files-1.0.4.txz > > /usr/ports/packages/x11/xorg-libraries-7.5.1.txz > > /usr/ports/packages/x11/xorg-macros-1.16.1.txz > > Creating package for xorg-7.5.2 > > This is not the problem but the goal with pkgng we need no more links > anywhere > except for pkgng itseld because the bootstrap in base relies on it. Does that mean all links in $CATEGORIES directories are unnecessary? If so, could we simply remove those directories instead of individual links? > > > > Second, it's very strange to show some filenames/links without any > > user-friendly messages. Users may not know that they are outdated links > > removed by bsd.pkgng.mk. > > > > e.g. while updating mail/postfix from 2.9.5 to 2.10, I got: > > ===> Building package for postfix-2.10.0,1 > > /usr/ports/packages/mail/postfix-2.9.5,1.txz > > /usr/ports/packages/ipv6/postfix-2.9.5,1.txz > > Creating package for postfix-2.10.0,1 > > > > You are right here, I'll remove the -v. Thanks! > > regards, > Bapt >