From owner-freebsd-current@FreeBSD.ORG Mon Nov 16 17:34:43 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71817106566C for ; Mon, 16 Nov 2009 17:34:43 +0000 (UTC) (envelope-from gnemmi@gmail.com) Received: from mail-yw0-f178.google.com (mail-yw0-f178.google.com [209.85.211.178]) by mx1.freebsd.org (Postfix) with ESMTP id 23E0E8FC1C for ; Mon, 16 Nov 2009 17:34:42 +0000 (UTC) Received: by ywh8 with SMTP id 8so5138519ywh.3 for ; Mon, 16 Nov 2009 09:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=hs9m4M37k1qjnNW8ZiE+eS1uaXQ7THFjQII432am7lc=; b=qY5U+XxmPJjzThc9X3MrUTkZEYfTqDL9I8FeF2DEKuI43UVMBKOnNSJVDho2Z4x94o +vKip8xRZzlqKDrTfAIZslLBgzNa8cJ6pEwo/fud5ERsTt+O9DWP3V9n0xzl1cBJdyBR Lk3wAthVWu9sO8ZuubkNy7oNcJANhIiRH/WnU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=AMrpgJcYfN+G7TiJGYz4WOKVbEJa8FwkAAGmUoTjtYU1caq5Z3C1c5Dob/j5m8s1Tr mHW3EsA3pfXsrojTa3ZSyPk3sbTCJ+qDi+P/QbGtVYgv3XGZ0DlDj7grLUH6sXbVyzF1 lFUOSMFNxuAi7U+ZLMxs1KL+yQPt6ZOoovtGc= Received: by 10.100.233.2 with SMTP id f2mr4702180anh.129.1258392878327; Mon, 16 Nov 2009 09:34:38 -0800 (PST) Received: from ?192.168.1.101? ([190.177.192.49]) by mx.google.com with ESMTPS id 8sm1752969yxg.6.2009.11.16.09.34.36 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 16 Nov 2009 09:34:37 -0800 (PST) From: Gonzalo Nemmi To: pyunyh@gmail.com Date: Mon, 16 Nov 2009 15:34:33 -0200 User-Agent: KMail/1.9.10 References: <20091111223751.GE15449@michelle.cdnetworks.com> <200911122039.31431.gnemmi@gmail.com> <20091116015816.GB1124@michelle.cdnetworks.com> In-Reply-To: <20091116015816.GB1124@michelle.cdnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200911161534.34028.gnemmi@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: Call for bge(4) testers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2009 17:34:43 -0000 On Sunday 15 November 2009 11:58:16 pm Pyun YongHyeon wrote: > On Thu, Nov 12, 2009 at 08:39:31PM -0200, Gonzalo Nemmi wrote: > > On Thursday 12 November 2009 8:05:50 pm Pyun YongHyeon wrote: > > > On Thu, Nov 12, 2009 at 07:12:44PM -0200, Gonzalo Nemmi wrote: > > > > On Thursday 12 November 2009 1:47:49 am Pyun YongHyeon wrote: > > > > > On Wed, Nov 11, 2009 at 02:37:51PM -0800, Pyun YongHyeon wrote: > > > > > > Hi, > > > > > > > > > > > > I had been working on fixing bus_dma(9) bugs and adding TSO > > > > > > capability to bge(4). Now TSO is supported for BCM5755 or > > > > > > newer controllers. Actually some pre-BCM5755 controllers > > > > > > also support TSO with the help of special firmware but the > > > > > > license issue and lower performance of firmware based TSO > > > > > > as well as TSO bug I intentionally excluded TSO support for > > > > > > pre-BCM5755 controllers. You can get the patch form the > > > > > > following URL. The diff was generated against latest HEAD. > > > > > > > > > > > > http://people.freebsd.org/~yongari/bge/bge.tso.1111.diff > > > > > > > > > > Eh, there was a typo so I regenerated the diff. > > > > > http://people.freebsd.org/~yongari/bge/bge.tso.1111-1.diff > > > > > > > > Hi > > > > Just wanted to know before getting on to it, will your patch > > > > help to resolve kern/136876? > > > > > > My diff includes a fix for assuming PCIe device control register > > > and MSI control registers would be reside in fixed address. And > > > from the pciconf output I see the your MSI control register is > > > located at different address. However bge(4) does not touch that > > > register for BCM5906 so I guess my diff may not fix the resume > > > issue. > > > > Thanks a lot for your prompt, clear and straight answer. > > Would you try attached patch for BCM5906 resume issue? Not sure > whether it help or not though. Hi Pyun! Sorry for the delay, I was out of town and just got back. I'm downloading RC3 as of now. Then I will install: edit make.conf edit src.conf buildworld buildkernel installkernel reboot mergemaster -p make installworld reboot cp bge.diff bge.patch cd /usr/src/sys/dev/bge && patch < /path/to/patch make make install clean kldunload if_bge kldload if_bge pciconf -lcvb ifconfig bge0 up acpiconf -s3 ... and hpefully .. resume from S3 .. Is that ok with you or would you like me to do it in another way? try some more stuff? Some test in particular? Best Regards and thanks for the patch Gonzalo Nemmi