From owner-freebsd-ruby@freebsd.org Mon Aug 3 14:25:01 2015 Return-Path: Delivered-To: freebsd-ruby@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE53A9B28D9 for ; Mon, 3 Aug 2015 14:25:00 +0000 (UTC) (envelope-from swills@mouf.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id BE08F1596 for ; Mon, 3 Aug 2015 14:25:00 +0000 (UTC) (envelope-from swills@mouf.net) Received: by mailman.ysv.freebsd.org (Postfix) id BAC8C9B28D8; Mon, 3 Aug 2015 14:25:00 +0000 (UTC) Delivered-To: ruby@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A05F79B28D7 for ; Mon, 3 Aug 2015 14:25:00 +0000 (UTC) (envelope-from swills@mouf.net) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C1941595 for ; Mon, 3 Aug 2015 14:25:00 +0000 (UTC) (envelope-from swills@mouf.net) Received: from mouf.net (swills@mouf [199.48.129.64]) by mouf.net (8.14.9/8.14.9) with ESMTP id t73EOjEi023901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 3 Aug 2015 14:24:50 GMT (envelope-from swills@mouf.net) Received: (from swills@localhost) by mouf.net (8.14.9/8.14.9/Submit) id t73EOihl023900; Mon, 3 Aug 2015 14:24:44 GMT (envelope-from swills) Date: Mon, 3 Aug 2015 14:24:44 +0000 From: Steve Wills To: Torsten Zuehlsdorff Cc: ruby@freebsd.org Subject: Re: [Gitlab] Current Status of the port Message-ID: <20150803142440.GA23813@mouf.net> References: <55BA3B55.5010000@toco-domains.de> <20150730152241.GC82229@mouf.net> <55BA4532.40107@toco-domains.de> <20150731135045.GA49801@mouf.net> <55BB8272.3060900@toco-domains.de> <20150731143935.GC49801@mouf.net> <55BB8B17.7050509@toco-domains.de> <20150731174219.GD49801@mouf.net> <55BF265B.9090401@toco-domains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <55BF265B.9090401@toco-domains.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Mon, 03 Aug 2015 14:24:50 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=HEADER_FROM_DIFFERENT_DOMAINS autolearn=unavailable autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.98.7 at mouf.net X-Virus-Status: Clean X-BeenThere: freebsd-ruby@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Ruby discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 14:25:01 -0000 --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 03, 2015 at 10:29:15AM +0200, Torsten Zuehlsdorff wrote: > Hello, >=20 > >> # cd /usr/ports/devel/rubygem-gitlab_git-rails41 > >> # portlint -AC > >> FATAL: Makefile: the last line of a slave port's Makefile has to be > >> .include "${MASTERDIR}/Makefile" > >> FATAL: Makefile: extra item "MASTERDIR" placed in the PORTNAME section. > >> FATAL: Makefile: extra item "PKGNAMESUFFIX" placed in the LICENSE sect= ion. > >> WARN: Consider to set DEVELOPER=3Dyes in /etc/make.conf > >> 3 fatal errors and 1 warning found. > > > > portlint doesn't really fully grok slave ports, unless I'm mistaken, so= use > > your judgement here, but the include does need to be last. >=20 > Okay, will fix. >=20 > >> When including the Master-Makefile in the last line, the PKGNAMESUFFIX > >> for example is not used. > > > > Change the master port to use ?=3D instead of =3D for the things you wa= nt to override. That's no problem. > This works, but increases the number of changed ports ;) >=20 > Also it just remove one FATAL error. This other 2 persists. Is this=20 > enough or should i do further research? In slave ports only, it's OK IMHO to ignore the issues from portlint about ordering. Steve --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJVv3miXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ5OEZBNDE0QTVDMkEwRUY5Q0ZEMEFEMERG NUNGNjJCMzIwN0IxQkExAAoJEPXPYrMgexuhY6EH/1C3DxfOYNPMU1ln0Rtc6d0k qZ+Wzy1y87wZBz98xGD/+CgsyXvq17gcVaweYfeTFZjwMjvBM2S9tJ0i1XugWs6h cWJnMNXX74AyLHR5aqqYMtA3mpanGh/ksS13r3AytRQtl4iYrcuhtw2SvMFxxbbd 6IkJWMGtAK5qCzhE4JUOTlt5mK0vlChUceNkTZlCLnCIVBtQQL24x+K2gAtUyDS0 ZvF7Fy2/6fHoJDnJeUWyp4EBbQP+em5WeMKGLDs30Pvyo14GiK8FSJH9s4lMyuXC BlePMY4RyO1GYUz7YuTjDOtxGIgBSU+42qZUrswKHG+f3uGp5JuI2gcc+0fe2vU= =8GMu -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--