From owner-freebsd-scsi@FreeBSD.ORG Wed Jul 14 14:00:19 2010 Return-Path: Delivered-To: scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B6DA106567B for ; Wed, 14 Jul 2010 14:00:19 +0000 (UTC) (envelope-from areilly@bigpond.net.au) Received: from nschwqsrv01p.mx.bigpond.com (nschwqsrv01p.mx.bigpond.com [61.9.189.231]) by mx1.freebsd.org (Postfix) with ESMTP id D721C8FC17 for ; Wed, 14 Jul 2010 14:00:18 +0000 (UTC) Received: from nschwotgx01p.mx.bigpond.com ([124.188.161.100]) by nschwmtas01p.mx.bigpond.com with ESMTP id <20100714115732.FJHR1369.nschwmtas01p.mx.bigpond.com@nschwotgx01p.mx.bigpond.com>; Wed, 14 Jul 2010 11:57:32 +0000 Received: from duncan.reilly.home ([124.188.161.100]) by nschwotgx01p.mx.bigpond.com with ESMTP id <20100714115731.HUXV7719.nschwotgx01p.mx.bigpond.com@duncan.reilly.home>; Wed, 14 Jul 2010 11:57:31 +0000 Date: Wed, 14 Jul 2010 21:57:31 +1000 From: Andrew Reilly To: Pawel Worach Message-ID: <20100714115731.GA14537@duncan.reilly.home> References: <51186C1C-E61D-4A9D-8A78-749F48E89CE0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51186C1C-E61D-4A9D-8A78-749F48E89CE0@gmail.com> User-Agent: Mutt/1.4.2.3i X-Authentication-Info: Submitted using SMTP AUTH LOGIN at nschwotgx01p.mx.bigpond.com from [124.188.161.100] using ID areilly@bigpond.net.au at Wed, 14 Jul 2010 11:57:31 +0000 X-RPD-ScanID: Class unknown; VirusThreatLevel unknown, RefID str=0001.0A090201.4C3DA62C.00DA,ss=1,fgs=0 X-SIH-MSG-ID: rxs7FNb2TAD0zmQs0WyzOwJxyArnqyN48Z4QX81loRIGTUDCp8DeQ9rEJvdRu8u6xD9IJhuENGQnaa/mTY3Rs9mK Cc: scsi@freebsd.org Subject: Re: [patch] fix aicasm build with clang. X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2010 14:00:19 -0000 On Wed, Jul 14, 2010 at 11:44:57AM +0200, Pawel Worach wrote: > sys/dev/aic7xxx/aicasm/aicasm_gram.y:1826:51: error: use of logical || with constant operand; switch to bitwise | or remove constant [-Wlogical-bitwise-confusion] > if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || AIC_OP_JZ) > ^ ~~~~~~~~~ > > Bug ? Looks like one to me. There's no constant value of AIC_OP_JZ that can make its inclusion in that line interesting, as is (it is probably non-zero, which means that the if-body is always executed. I think that your patch is almost certainly correct. [What down-stream effect does this bug have on the SCSI controller microcode in question?] Cheers, -- Andrew