From owner-cvs-all Sun Jun 18 6:26:20 2000 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (tun.AwfulHak.org [194.242.139.173]) by hub.freebsd.org (Postfix) with ESMTP id 2F1BB37B70E; Sun, 18 Jun 2000 06:26:12 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.awfulhak.org [172.16.0.12]) by Awfulhak.org (8.9.3/8.9.3) with ESMTP id OAA22178; Sun, 18 Jun 2000 14:22:03 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.9.3/8.9.3) with ESMTP id OAA68493; Sun, 18 Jun 2000 14:21:49 +0100 (BST) (envelope-from brian@Awfulhak.org) Message-Id: <200006181321.OAA68493@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.1.1 10/15/1999 To: Johan Karlsson Cc: brian@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, brian@hak.lan.awfulhak.org Subject: Re: cvs commit: src Makefile.inc1 In-Reply-To: Message from Johan Karlsson of "Sun, 18 Jun 2000 11:42:40 +0200." <200006180942.LAA77690@numeri.campus.luth.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 18 Jun 2000 14:21:49 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > brian 2000/06/09 03:42:39 PDT > > > > Modified files: > > . Makefile.inc1 > > Log: > > Set KERNEL=${INSTALLKERNEL} doing a make install in /sys/conf > > > > Revision Changes Path > > 1.150 +2 -2 src/Makefile.inc1 > > === diff === > @@ -398,7 +398,7 @@ buildkernel: > installkernel: > cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \ > ${IMAKEENV} MACHINE=${MACHINE} KERNEL=${INSTALLKERNEL} \ > - ${MAKE} install > + ${MAKE} KERNEL=${INSTALLKERNEL} install > ============ > > > Hi Brian, > I'm trying to figure out why this change was needed, but I just > do not understand. > > KERNEL is set as part of the env in the line above and if that > is not enough I think it needs to changed in a lot of other places. > > Can you please tell me in what context this change is needed. > > The thing is that I'm working on a new versoin of the patch > is PR kern/17698 which also knows about /modules. > > Thanks > Johan K On one of my machines at work, I have the following in /etc/make.conf: KERNEL=? DBT1 DBT5 UKNOWN1835 I expect to build all three kernels as a result, but when I ``make installkernel'', Makefile.inc1 takes steps to set INSTALLKERNEL to DBT1 - the first item in the KERNEL list. When the sys/conf/Makefile.$arch is used with an ``install'' target, it finds KERNEL in /etc/make.conf and overrides the environment setting, making a rather miserable attempt at running ${INSTALL}. It would probably be cleaner if I had KERNEL?= DBT1 DBT5 UNKNOWN1835 INSTALLKERNEL?= DBT1 in make.conf, but I didn't think that was the correct solution as INSTALLKERNEL is just overridden in src/Makefile.inc1. Perhaps the correct solution is to default INSTALLKERNEL to the first item in the KERNEL list in both make files ? -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message