From owner-cvs-all Mon Jan 22 17:30:49 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id 8C02937B404; Mon, 22 Jan 2001 17:30:25 -0800 (PST) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.1/8.11.1) with ESMTP id f0N1V4U20760; Tue, 23 Jan 2001 01:31:04 GMT (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.1/8.11.1) with ESMTP id f0N1XB107675; Tue, 23 Jan 2001 01:33:11 GMT (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200101230133.f0N1XB107675@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Peter Wemm Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src Makefile.inc1 In-Reply-To: Message from Peter Wemm of "Sun, 21 Jan 2001 23:29:49 PST." <200101220729.f0M7TnZ86477@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 23 Jan 2001 01:33:11 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > peter 2001/01/21 23:29:49 PST > > Modified files: > . Makefile.inc1 > Log: > Using "KERNEL" for buildkernel was a very very bad mistake. $KERNEL is > already used by the kernel makefiles themselves, and this leads to a lot > of trouble when people put "KERNEL=MYKERNEL" in make.conf. Bite the bullet > and change it to KERNCONF instead, before it gets too far entrenched. > > The kernel Makefiles use ${KERNEL} as the name of what to install the > kernel as, eg: /boot/${KERNEL}/kernel or /${KERNEL}. This leads to much > unhappiness with things like /LOCAL instead of /kernel. buildkernel is > severely limited as it is only useful directly after a buildworld. > > Reviewed by: jhb > > Revision Changes Path > 1.183 +5 -5 src/Makefile.inc1 I've had KERNEL= in /etc/make.conf for several months and on lots of machines. It leads to no trouble that I can see with buildkernel/ installkernel. Doing this may be broken for the old config, cd /blah/blah/compile/blah, make method, so why not fix that rather than breaking everyone's current configuration ? Assuming you've got a good argument for breaking things, a HEADS UP is probably in order. -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message