From owner-freebsd-python@freebsd.org Fri Sep 6 22:47:18 2019 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 16D82DA388 for ; Fri, 6 Sep 2019 22:47:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46QCP16yJvz3GbZ for ; Fri, 6 Sep 2019 22:47:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id ECEE2DA386; Fri, 6 Sep 2019 22:47:17 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ECB2BDA385 for ; Fri, 6 Sep 2019 22:47:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46QCP160Hqz3GbX for ; Fri, 6 Sep 2019 22:47:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 97B0B23E68 for ; Fri, 6 Sep 2019 22:47:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x86MlHuV015610 for ; Fri, 6 Sep 2019 22:47:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x86MlHHL015609 for python@FreeBSD.org; Fri, 6 Sep 2019 22:47:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 240375] [NEW PORT] www/py-isso: A commenting server similar to Disqus Date: Fri, 06 Sep 2019 22:47:17 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: cc flagtypes.name keywords bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2019 22:47:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240375 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |python@FreeBSD.org, | |rt@scientifics.de Flags| |maintainer-feedback?(rt@sci | |entifics.de) Keywords| |feature, needs-patch, | |needs-qa Status|New |Open --- Comment #1 from Kubilay Kocak --- Thank you for your new port submission Ren=C3=A9 There's a number of review items that need to be taken care of, so it would= be great if you could run the port through QA (portlint, and poudriere in particular).=20 For more details and instructions see: https://www.freebsd.org/doc/en/books/porters-handbook/testing.html At a quick glance: - Remove "A " from COMMENT (portlint should complaint about this) - COMMENT for Python ports should match setup.py:description with portlint compliant changes where necessary (COMMENT=3DLightweight Disqus alternative) - Use GH_* variables (eg: GH_TAGNAME) not COMMIT_ID - Use MASTER_SITES=3DCHEESESHOP unless there is a compelling temporary reas= on to use an alternative source (like GitHub), such as missing test or test data files. - Add python as a secondary CATEGORIES - NO_ARCH is out of order (put it after USES, portlint should complain about this) - Dont hardcode paths (like /usr/local/etc), as people can change their PRE= FIX. Use ${ETCDIR} instead) - cffi is missing as a BUILD_DEPENDS (setup_requires=3D["cffi>=3D1.3.0"],) - conditional Python 2.7 dependencies are missing (':python_version=3D=3D"2= .7"': ['ipaddr>=3D2.1', 'configparser']) - Note: these should be moved in upstrea= m code to install_requires with environment markers, they are not optional for python2.7) - For all *_DEPENDS, match the version specifiers are closely as possible. RUN_DEPENDS currently specify >0, but setup.py says, for example: misaka>=3D2.0,<3.0' werkzeug>=3D0.9 ipaddr>=3D2.1' --=20 You are receiving this mail because: You are on the CC list for the bug.=