From owner-dev-commits-src-main@freebsd.org Sun Jan 10 13:24:28 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 68E844CC15E; Sun, 10 Jan 2021 13:24:28 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DDHcX2Trgz4cxy; Sun, 10 Jan 2021 13:24:28 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:470:7a58:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 2E8B926C52; Sun, 10 Jan 2021 13:24:28 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:470:7a58::1d5d:d377:dcb4:cd20] (unknown [IPv6:2001:470:7a58:0:1d5d:d377:dcb4:cd20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 3E923420F8; Sun, 10 Jan 2021 14:24:26 +0100 (CET) From: Dimitry Andric Message-Id: <32828B4F-9876-42F5-9110-21418960496D@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_D923C41E-DE7E-485F-92AC-6DE87C0F6B37"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: git: 821aa63a0940 - main - ncurses: only keep the version with widechar support Date: Sun, 10 Jan 2021 14:24:15 +0100 In-Reply-To: Cc: Kyle Evans , Baptiste Daroussin , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org To: Gordon Bergling References: <202101051302.105D24lW041218@gitrepo.freebsd.org> <20210107135842.lji6ydbajmzxqiuq@ivaldir.net> X-Mailer: Apple Mail (2.3445.104.17) X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jan 2021 13:24:28 -0000 --Apple-Mail=_D923C41E-DE7E-485F-92AC-6DE87C0F6B37 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 8 Jan 2021, at 16:43, Gordon Bergling wrote: >=20 > On Fri, Jan 08, 2021 at 09:21:01AM -0600, Kyle Evans wrote: >> On Thu, Jan 7, 2021 at 7:59 AM Baptiste Daroussin = wrote: >>> On Thu, Jan 07, 2021 at 07:53:47AM -0600, Kyle Evans wrote: >>>> On Tue, Jan 5, 2021 at 7:02 AM Baptiste Daroussin = wrote: ... > thanks for the additional bugfix. It would be good to provide = somewhere in > UPDATING some information about 'depend-cleanup.sh'. I use FreeBSD = since > about 20 years, and even as a committer I had never heard something = about > 'depend-cleanup.sh' before. IIRC emaste added this script recently. It used to be a bunch of commands directly in the top-level Makefiles, but this was getting a bit annoying to maintain. What's more, it was difficult to test the commands separately from the rather heavy "let's do a full buildworld" scenario. So now it is just a shell script, and you can run it by hand to test if any changes you're making to it work as expected, before committing. (Note that I consider all the "depend cleanup" stuff to be a fig leaf for a rather glaring deficiency in our build system. An ugly kludge. :) -Dimitry --Apple-Mail=_D923C41E-DE7E-485F-92AC-6DE87C0F6B37 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCX/r//wAKCRCwXqMKLiCW o+MeAJ9EphzWN+3xRg9A0L5lmNqqq4X8fgCdHRhwEQxea48JixhcJzf2IqWWNYs= =nlX3 -----END PGP SIGNATURE----- --Apple-Mail=_D923C41E-DE7E-485F-92AC-6DE87C0F6B37--