From owner-freebsd-scsi  Sun Sep 29 15:51:08 1996
Return-Path: owner-freebsd-scsi
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id PAA17286
          for freebsd-scsi-outgoing; Sun, 29 Sep 1996 15:51:08 -0700 (PDT)
Received: from deacon.cogsci.ed.ac.uk (deacon.cogsci.ed.ac.uk [129.215.144.7])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id PAA17234
          for <freebsd-scsi@FreeBSD.org>; Sun, 29 Sep 1996 15:50:59 -0700 (PDT)
Received: from pitcairn.cogsci.ed.ac.uk (pitcairn.cogsci.ed.ac.uk [129.215.197.19]) by deacon.cogsci.ed.ac.uk (8.6.10/8.6.12) with ESMTP id XAA02108; Sun, 29 Sep 1996 23:50:57 +0100
Date: Sun, 29 Sep 1996 23:50:56 +0100
Message-Id: <1348.199609292250@pitcairn.cogsci.ed.ac.uk>
From: Richard Tobin <richard@cogsci.ed.ac.uk>
Subject: Re: HP T4000s tape drive
To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch), freebsd-scsi@FreeBSD.org
In-Reply-To: J Wunsch's message of Sun, 29 Sep 1996 18:57:27 +0200 (MET DST)
Organization: just say no
Cc: richard@cogsci.ed.ac.uk
Sender: owner-freebsd-scsi@FreeBSD.org
X-Loop: FreeBSD.org
Precedence: bulk

> > + #define QIC_3095	0x45
> What do you need this for?

I don't use it, but the other tape types have #defines, and there are
a couple of switch statements that switch on tape type and I'm not
sure whether they should include this one.  In particular, there's one
that decides whether to use two file marks for end-of-data.  Someone
who understands the code better than me should look at it!

> > ! #define SCSI_2_MAX_DENSITY_CODE	0xff	/* SCSI 2 spec is out of date! */
> and this?  The entire check for a ``max density'' could go.

Well the user passes it in as a u_int32 (in the ioctl) and it gets
assigned to a u_char (for the scsi_select), so perhaps a range check
is still appropriate?

> Justin, would commiting this conflict with your branch?  (Ok, i can
> also check myself.)

Remember it was a patch relative to 2.1.0-RELEASE!

-- Richard