From owner-svn-src-head@freebsd.org Sun Feb 23 03:53:23 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A6798257C9C; Sun, 23 Feb 2020 03:53:23 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48QBBC35mJz44vB; Sun, 23 Feb 2020 03:53:23 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 531EBACC0; Sun, 23 Feb 2020 03:53:23 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f181.google.com with SMTP id w47so4344628qtk.4; Sat, 22 Feb 2020 19:53:23 -0800 (PST) X-Gm-Message-State: APjAAAVByDDj1/mvzjUKq0l5M8rs+cMWfdBgNpI/lv+/9SdOsOt851IN ZcHN/ndcM4XaAIsIk2Bfw7smCHHdhWqi8WWAhgA= X-Google-Smtp-Source: APXvYqxvpAHUzibyxpXHVE775Ke3zXbLRaWmgonhb0ocaTPcWRgvSccXWtkHPGCXyTLbeFjpn8hsJmOWgRUVVAy2U2o= X-Received: by 2002:aed:3f70:: with SMTP id q45mr39651094qtf.310.1582430002850; Sat, 22 Feb 2020 19:53:22 -0800 (PST) MIME-Version: 1.0 References: <202002230332.01N3WCRn083904@repo.freebsd.org> In-Reply-To: <202002230332.01N3WCRn083904@repo.freebsd.org> From: Kyle Evans Date: Sat, 22 Feb 2020 21:53:11 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r358257 - in head/sys: kern sys To: Ryan Libby Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Feb 2020 03:53:23 -0000 On Sat, Feb 22, 2020 at 9:32 PM Ryan Libby wrote: > > Author: rlibby > Date: Sun Feb 23 03:32:11 2020 > New Revision: 358257 > URL: https://svnweb.freebsd.org/changeset/base/358257 > > Log: > vfs: quiet -Wwrite-strings > > Reviewed by: kib, markj > Differential Revision: https://reviews.freebsd.org/D23797 > Only tangentially related to this, I have a patch in one of my WIP branches that const-poisons vn_fullpath()'s retbuf parameter, if that's of any interest. Many consumers will set a default value to a statically allocated string before passing it in as the retbuf -- I had a use-case where I'd be trying to do similar but with a function that actually returns a const char *, but that particular case may not get committed. I can post the patch to phabricator if anyone cares about this -- the impact on callers isn't actually all that bad, basically just shuffling around declarations. There's only one case where it ends up introducing some __DECONST ugliness because the caller writes it out with uiomove(). Thanks, Kyle Evans