From nobody Mon Nov 3 20:30:17 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d0jrT6Xbqz6FjGL for ; Mon, 03 Nov 2025 20:30:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d0jrT17tyz3Lrc for ; Mon, 03 Nov 2025 20:30:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762201817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DbWFvD5NXgj1XzQRs/IrYtVbpPbkZXImOHp2A04mFhU=; b=reBu3RYsZibLEMqt3FVv/ByLYAXaulnjsrcnvYLZA5dtiwW76f4J39IG86dS0ywARJokKv MIEX/9Nxqfw68+gtSO9qIxGl6R8zuXe1Na5Uoq2GjkbQ24IOtuRcKb5YkIvI8sp/l4ou3B pw2sk/YVoe1u1HrSsS+lQyRFUUosiigoioBOH6h3kFbMI4z1ER6TOxu9DGlAZ8AgzBYqNt aBMN/B/tfekZbZTI2M9bOPBbG80686ZagUmYM0PaR4Cc+zO19wEjRNVkgE8Iz0HyAElAPD 2Hc/AfnFXABBAy9S3O/yEkfQTwLd4m1rE4Mu+ZUhBW82gjgQ0AKde7Tn3OOQTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762201817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DbWFvD5NXgj1XzQRs/IrYtVbpPbkZXImOHp2A04mFhU=; b=Hwzz3IM4yOd0xihm+oS/JW1YjwioUmFWjNnF+GRmVWwgtMtcDAS+Z+VvvnyHvnPQC3n8tb x91YoJVCvP/njLAiQ2eqd3geeU60fISa1EacyMa3f755bvT/1tjlJjHkcufzDkwaf3OhFN 71fnQtR6MS9bIYgQ1u2J8JJXu2vdQrTI5j1On15lv4Wfdo4lqP5eI7A2+pkI+G2XVCyVPu Zb5DKEAc++THZ4aqaHVf9qWn72ePKbzbdOfZ6wXLPoptJmXc6RqpMKhtuyPYM4+f9tJVW3 Om4hcl/Hrt/twhaWXaamN62hINlYKTn+kfLvYjGo2ma9zlz4732u3Xg03W4BRw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762201817; a=rsa-sha256; cv=none; b=iQQrouz5GrAbhI4G+RvoBECiH0xNO1TxqFZ/iJctQ1unNeV6mW66QFmAfyZok0O109/m0L WOP0QTSChFGFBCy7DRDNlRRvoQufAUKvyH018fv10s49en+MbCvuFHzziEQ7UBl3KCSEDW nmPsGETDPYZ70gt3+4IproYCkU8hmF6L00XBavydb3/5cJqAJAI4mqMdn9v16b5RfLGr/i aHDQ8g0GIgMU7LpacOhgviAUGogZW4tCzMxclWznjgAj7+VsE7GACqghYY2cbDmCT72Kj3 feRCN6/ao9T7Gt8QJIPIiX/FV3YUX+hb9jPpTdLjh7hjxYYBvyqlJEcTnVYbzA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d0jrT0Bxzz9jB for ; Mon, 03 Nov 2025 20:30:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 5A3KUGbs076108 for ; Mon, 3 Nov 2025 20:30:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 5A3KUGOv076107 for net@FreeBSD.org; Mon, 3 Nov 2025 20:30:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 283820] ixl multicast filter problems Date: Mon, 03 Nov 2025 20:30:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283820 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch releng/15.0 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D97fa2bfeab3de726f096ff2fb991da79e= a8285fb commit 97fa2bfeab3de726f096ff2fb991da79ea8285fb Author: Bhosale, Yogesh AuthorDate: 2025-10-16 20:02:45 +0000 Commit: Colin Percival CommitDate: 2025-11-03 20:29:19 +0000 ixl(4): fix multicast promiscuous mode state tracking and filter manage= ment This change reapplies the improvements from commit 89e7335 and adds additional fixes and code optimizations on top of it. The ixl driver supports up to 128 multicast filters in hardware. When t= his limit is exceeded, the driver should enable multicast promiscuous mode. When the count drops below 128, it should disable promiscuous mode and restore individual filters. The driver previously had problems that could corrupt multicast filters list. The main issue was that ixl_dis_multi_promisc() would attempt to disable promiscuous mode without checking if it was actually enabled, potential= ly corrupting existing filters. There was also no state tracking across dr= iver functions, leading to redundant operations. This change adds an IXL_FLAGS_MC_PROMISC flag to track the multicast promiscuous mode state. The flag is set when enabling promiscuous mode = and cleared when disabling it. Early return checks prevent redundant operat= ions when the mode is already in the desired state, avoiding filter corrupti= on and unnecessary hardware calls. Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com Approved by: re (cperciva) PR: 283820 Approved by: kbowling (mentor) Tested by: gowtham.kumar.ks_intel.com Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D52549 (cherry picked from commit 46a8a1f08f88c278e60ebb6daa7a551eb641c67b) (cherry picked from commit f3c442950de3b34dda24ecb258171c32d161b1fd) sys/dev/ixl/if_ixl.c | 27 +++++++++++- sys/dev/ixl/ixl.h | 1 + sys/dev/ixl/ixl_pf_main.c | 110 +++++++++++++++++++++++++++++++++++++++---= ---- 3 files changed, 120 insertions(+), 18 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=