From owner-svn-src-head@FreeBSD.ORG Tue Sep 4 00:51:55 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 39156106567C for ; Tue, 4 Sep 2012 00:51:55 +0000 (UTC) (envelope-from pfg@freebsd.org) Received: from nm27-vm0.bullet.mail.sp2.yahoo.com (nm27-vm0.bullet.mail.sp2.yahoo.com [98.139.91.232]) by mx1.freebsd.org (Postfix) with SMTP id 079178FC16 for ; Tue, 4 Sep 2012 00:51:55 +0000 (UTC) Received: from [98.139.91.67] by nm27.bullet.mail.sp2.yahoo.com with NNFMP; 04 Sep 2012 00:51:54 -0000 Received: from [98.139.91.40] by tm7.bullet.mail.sp2.yahoo.com with NNFMP; 04 Sep 2012 00:51:54 -0000 Received: from [127.0.0.1] by omp1040.mail.sp2.yahoo.com with NNFMP; 04 Sep 2012 00:51:54 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 663441.43893.bm@omp1040.mail.sp2.yahoo.com Received: (qmail 68930 invoked by uid 60001); 4 Sep 2012 00:51:54 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1346719914; bh=VwzM9lplTDI7wEtvlN2fX9ep4Dq7we2DljWOo3g/NR0=; h=X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=En7SqWngZiJdTSZ2v1OgN3/yb49CcugRJ9KktRhlGKccOpMXrUADv4HkEn0qTdGw7MXN1tTlZnSWHt51xshx0A7Ts4VHmiUg8q4+3oufWQn2R6dZoZ2XQdTyXFpn7F7hHiOIRqS9G+KAV2NaNI5yUINCnbKVIw6m/ngZvPOHOGo= X-YMail-OSG: G9j.jJsVM1m1vstG8Jv2ZaVbA4XeRUdba6FUvJ8hEKbbRHB uon3HpGWj7MHN6Q0JRD26qrHaq6zjK89moxj03qPqq9YpsGVPONeqq.cZrgw NrYvklQGzxt00fAIo8SjEOvtmpbTCm_ucP0wKd6blmnQ53F621xJYRs4EvFf OEqNzW1Gobl9jyH.XULKcO8Q02RFrJSSAnAuoftLhzxsMn7xD9ut85tElIlW jG2c6KW3Xy3Ys9N6jE1cHeBML7qyqwCVb3_66g5wMZ_P3E1kETHvKNbwZEOg CktRuayl6uR63uCM5hr9V743GolACPUS9XxRp1VZzjwuZUiMBOslk2VF7oaD 0sZFjTYVCoQX64zTpr54g9_YjZeROszmNA347pM4LzYU5rCz2KR6Jh5o9plv o2HiYOuhByLloiFD.ps1iwDnh2tI5jCkmPba.lT8n.q.RicXCSUDbTlTehwj ooUlbKDbJos0Gn2KJBYNn01SJXZUr6NuX90wiuQxuMGltql3wSPBWrEjEo8f cYTleUbIC.US.jr7ePoiMWSXY6kx3WKl9tEkdOQkNky.QoU9IX8rRvWA5aPL 7yciWLjnxWIm5jnCfZrJUL.OlFbrg5WEE Received: from [200.118.157.7] by web113520.mail.gq1.yahoo.com via HTTP; Mon, 03 Sep 2012 17:51:53 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailWebService/0.8.121.416 References: <20120903073133.GB33100@deviant.kiev.zoral.com.ua> <1346681599.92069.YahooMailClassic@web113502.mail.gq1.yahoo.com> <20120903144050.GN33100@deviant.kiev.zoral.com.ua> Message-ID: <1346719913.68772.YahooMailNeo@web113520.mail.gq1.yahoo.com> Date: Mon, 3 Sep 2012 17:51:53 -0700 (PDT) From: Pedro Giffuni To: Konstantin Belousov In-Reply-To: <20120903144050.GN33100@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r240060 - in head: include/rpc sys/rpc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Pedro Giffuni List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2012 00:51:55 -0000 ...=0A>________________________________=0A>=0A>From: Konstantin Belousov=0A= >=A0=0A>...=0A>=0A>>=A0 =0A>> PR 137443=0A>From the PR, I fail to see what = is the problem in our headers, and why=0A>the issue is not in some third-pa= rty C++ code.=0A>=0A>It is definitely has nothing to do with C++ name mangl= ing.=0A>=0A=A0=0AHmm.. yes, not a mangling issue but it is rather weird tha= t it happens on C++.=0ASalome is not a toy app.=0A=0A>> =0A>> > Although no= t very useful due to many other namespace=0A>> > pollution problems=0A>> > = in the rpc headers, __rpc_xdr is in the=0A>> > implementation-reserved name= space,=0A>> > while XDR is not.=0A>> > =0A>> =0A>> The forced reference her= e is {Open}Solaris:=0A>> =0A>> http://src.illumos.org/source/xref/illumos-g= ate/usr/src/uts/common/rpc/xdr.h=0A>> =0A>> OpenGrok found no reference to = __rpc_xdr=0A>> in OpenSolaris/illumos.=0A>I see, Solaris does=0A>=A0=A0=A0 = typedef struct XDR { ... } XDR;=0A>and we now use the same trick.=0A>=0A>So= my objections, if any, were against the commit message and not the actual= =0A>code change then.=0A>=0A=A0=0AQuite definitely :(=A0.. I mixed two diff= erent issues that I was trying to solve=0A(and one of them was not an issue= at all). I will do a better job when I=0AMFC.=0A=A0=0AThanks for checking = though: I do feel nervous when touching a standard=0Aheader=A0even if it's = just to follow a change from upstream!=0A=A0=0A=A0=0APedro.