Date: Sat, 28 Mar 2009 18:17:38 +0100 (CET) From: Thomas-Martin Seck <tmseck@web.de> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/133159: [Maintainer] www/squid, www/squid30: fix endianness handling in squid_kerb_auth Message-ID: <200903281717.n2SHHcH4039670@hardy.tmseck.homedns.org> Resent-Message-ID: <200903281720.n2SHK2YG087514@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 133159
>Category: ports
>Synopsis: [Maintainer] www/squid, www/squid30: fix endianness handling in squid_kerb_auth
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 28 17:20:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Thomas-Martin Seck
>Release: FreeBSD 7.1-STABLE i386
>Organization:
a private site in Germany
>Environment:
FreeBSD ports collection as of March 28, 2009.
>Description:
The squid_kerb_auth helper needs to know about the endianness of the system
at compile time. Its author suggests to use -D__LITTLE_ENDIAN__ in the
program's Makefile and this is the solution proposed in ports/131878. Since
FreeBSD (and FreeBSD ports) might be used on big-endian architectures as
well as on little endian architectures I decided to instrument an already
present endianness check directly in the affected source file instead.
Bump PORTREVISION since this affects the content (and functionality) of
the port's binary package.
This update addresses ports/131878 which can be closed.
>How-To-Repeat:
>Fix:
Apply this patch to www/squid:
Index: Makefile
===================================================================
--- Makefile (.../www/squid) (revision 1567)
+++ Makefile (.../local/squid) (revision 1567)
@@ -76,6 +76,7 @@
PORTNAME= squid
PORTVERSION= 2.7.${SQUID_STABLE_VER}
+PORTREVISION= 1
CATEGORIES= www
MASTER_SITES= ftp://ftp.squid-cache.org/pub/%SUBDIR%/ \
ftp://mirrors.24-7-solutions.net/pub/squid/%SUBDIR%/ \
Index: files/patch-squid_kerb_auth
===================================================================
--- files/patch-squid_kerb_auth (.../www/squid) (revision 1567)
+++ files/patch-squid_kerb_auth (.../local/squid) (revision 1567)
@@ -557,3 +557,25 @@
#define gss_nt_service_name GSS_C_NT_HOSTBASED_SERVICE
#else
#include <gssapi/gssapi.h>
+--- helpers/negotiate_auth/squid_kerb_auth/spnegohelp/derparse.c.orig 2007-05-15 01:36:32.000000000 +0200
++++ helpers/negotiate_auth/squid_kerb_auth/spnegohelp/derparse.c 2009-03-28 17:21:54.000000000 +0100
+@@ -22,12 +22,19 @@
+ //
+ /////////////////////////////////////////////////////////////
+
++#include "config.h"
+ #include <stdlib.h>
+ #include <stdio.h>
+ #include <memory.h>
+ #include "spnego.h"
+ #include "derparse.h"
+
++#ifdef WORDS_BIGENDIAN
++#undef __LITTLE_ENDIAN__
++#else
++#define __LITTLE_ENDIAN__ 1
++#endif
++
+ //
+ // The GSS Mechanism OID enumeration values (SPNEGO_MECH_OID) control which offset in
+ // the array below, that a mechanism can be found.
Apply this patch to www/squid30:
Index: Makefile
===================================================================
--- Makefile (.../www/squid30) (revision 1567)
+++ Makefile (.../local/squid30) (revision 1567)
@@ -61,6 +61,7 @@
PORTNAME= squid
PORTVERSION= 3.0.${SQUID_STABLE_VER}
+PORTREVISION= 1
CATEGORIES= www
MASTER_SITES= ftp://ftp.squid-cache.org/pub/%SUBDIR%/ \
ftp://mirrors.24-7-solutions.net/pub/squid/%SUBDIR%/ \
Index: files/patch-squid_kerb_auth
===================================================================
--- files/patch-squid_kerb_auth (.../www/squid30) (revision 1567)
+++ files/patch-squid_kerb_auth (.../local/squid30) (revision 1567)
@@ -466,3 +466,25 @@
#define gss_nt_service_name GSS_C_NT_HOSTBASED_SERVICE
#else
#include <gssapi/gssapi.h>
+--- helpers/negotiate_auth/squid_kerb_auth/spnegohelp/derparse.c.orig 2009-03-28 17:01:45.000000000 +0100
++++ helpers/negotiate_auth/squid_kerb_auth/spnegohelp/derparse.c 2009-03-28 17:06:55.000000000 +0100
+@@ -22,12 +22,19 @@
+ //
+ /////////////////////////////////////////////////////////////
+
++#include "config.h"
+ #include <stdlib.h>
+ #include <stdio.h>
+ #include <memory.h>
+ #include "spnego.h"
+ #include "derparse.h"
+
++#ifdef WORDS_BIGENDIAN
++#undef __LITTLE_ENDIAN__
++#else
++#define __LITTLE_ENDIAN__ 1
++#endif
++
+ //
+ // The GSS Mechanism OID enumeration values (SPNEGO_MECH_OID) control which offset in
+ // the array below, that a mechanism can be found.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903281717.n2SHHcH4039670>