From nobody Thu May 23 13:54:58 2024 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VlV6p4Rvnz5LmKM for ; Thu, 23 May 2024 13:55:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VlV6p3mvPz4JLW for ; Thu, 23 May 2024 13:55:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-51f4d2676d1so7854622e87.3 for ; Thu, 23 May 2024 06:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1716472512; x=1717077312; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=STxqNjn+Nxtp1EZZFeBFu2N05YHa3gDyxYHCxAdeqqQ=; b=JeLP+r40+pErl519F2b892QfNTaFXFGaLFJuRRyR/D4ihgf+3fMjBWPZ4tRP+ThX3Z +kTcd7CLaaCZ0orE0sSiifTlquyR0+PKGbPV9U250vNxFBKTPfk6avM3lsi0NhiUFJXG z2+KxxwvsKUKTMioGdNTRlf0+YZmFphT4nDaYi/L35NMU7J2Vz/Us5UqoG86yXpGwHPU /ZpFDrSw0Rv9qzPCEkquIxSBdDQEf8wMsLbdDukgIn+VGTHfu6VEs65WzU9y2NrCTBj8 oNsav9aPj2lGFSZUhZO9Ipju7/mA5jXE4cUFAlx+Fk6rDIXO10x5gQANqppUWmk/muY0 qJUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716472512; x=1717077312; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=STxqNjn+Nxtp1EZZFeBFu2N05YHa3gDyxYHCxAdeqqQ=; b=sSdlVbmZ98oFGGyxb8ufll6AnQS4E4G0pNtpdGnIT/sVz6Z82zJ1tQ331JXOgCNCiB 89JMR5cRdaQn3Qu2zXXqBwj9qSj35Bj2aractZdX/HsxCUcEMEQhNQi1vFpGQez4rKY0 lNQJuMGd92+XMWCr11RovVkl6gbVEz1V1s6fySTB4gXM4BHQVJ4F5c7f7aAXpPFwS1nQ FPXz8DgN8jI3rrcTUFfkEwwlNheWKa37OZUwmAfwOiDqwL97Bd2Jyw0A+mAqnKcPBhfB LevH9rl+UvooU0iYNGUlIX1d2qAHwX2x4QLUC9eZJnfdcYgyUSwr98CAQNZHH0myNit5 QWFQ== X-Forwarded-Encrypted: i=1; AJvYcCXDUk9KuYf9k9QrHAtzJLO69VxpLdaX4UTSTuQahVZeWX5NKczZtVBTlk8ks/r4Bpet/8gMu3Fyc4Sh6cEzK2sGej2P8hzbfuzb7FE= X-Gm-Message-State: AOJu0YyAgG8gVQUFgMRlaqNxIBNA83kMXDMyIf4/7NGTwj0X3KFQ2Ual 2V4nxGBprC3SsJzQ/1+uKBbSTI6R06hCJ5Bevwp49cYwt+0cvhGxHnGO/fMprj1NJyd75wqFpdQ qBR20KQ5fTKxRfiCA3Gm3P6jMesjNVEml/D1hYg== X-Google-Smtp-Source: AGHT+IGnCb4TxTuZdXEIreQUTCE3QRGPQEWEjrlHmxmdscSJckbRtB427bYDL/dOd9rR8/XOaZXzKOs5iBXGpTk9s4M= X-Received: by 2002:a19:4308:0:b0:528:649b:d7bb with SMTP id 2adb3069b0e04-528649bd990mr1048954e87.0.1716472511742; Thu, 23 May 2024 06:55:11 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@FreeBSD.org MIME-Version: 1.0 References: <087AB4C4-9CE0-4024-8E1B-4C636014C8CC@lysator.liu.se> In-Reply-To: From: Warner Losh Date: Thu, 23 May 2024 07:54:58 -0600 Message-ID: Subject: Re: Trying to understand CAM (and the cciss driver) To: Marek Zarychta Cc: Peter Eriksson , FreeBSD Hackers Content-Type: multipart/alternative; boundary="000000000000545d6806191f667e" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4VlV6p3mvPz4JLW --000000000000545d6806191f667e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 23, 2024, 7:20=E2=80=AFAM Marek Zarychta wrote: > Dnia Thu, May 09, 2024 at 07:58:32PM +0200, Peter Eriksson napisa=C5=82(a= ): > > Hi, > > > > I=E2=80=99m trying to fix a bug in the cciss driver that has been there > =E2=80=9Cforever=E2=80=9D when using it with an HP H241 SAS HBA card. > > The driver works fine when all (SAS, spinning rust) drives are behaving > well, but when some of them are starting to go bad it often goes into spi= n > and either hangs the kernel or panics. I=E2=80=99ve been trying to add > instrumentation to it in order to pin-point the problem and have been > attempting some workarounds (like clearing cr_complete since without that > hack sometime the driver get many many non-busy repeated requests with th= e > same =E2=80=9Ctag=E2=80=9D and then It panics with: > (...) > > > > - Any suggestions? (Probably not but I thought I=E2=80=99d ask anyway := -) > > > > Hello Peter, > > I have no suggestion but a question. Does the panic happen with > https://reviews.freebsd.org/D25155 applied ? I am using your patch from > this review with a few drives. It's handy and still builds fine on > 15-CURRENT. > I think he'll still get panics from that since his panics were from bugs in the recovery code, i think, and that patch doesn't really change that code. There may be more diagnostics produced from that code, so it may be worth trying... Warner Cheers > > -- > Marek Zarychta > > --000000000000545d6806191f667e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, May 23, 2024, 7:20=E2=80=AFAM Marek Zarychta &= lt;zarychtam@plan-b.pwste.= edu.pl> wrote:
Dnia Thu, May= 09, 2024 at 07:58:32PM +0200, Peter Eriksson napisa=C5=82(a):
> Hi,
>
> I=E2=80=99m trying to fix a bug in the cciss driver that has been ther= e =E2=80=9Cforever=E2=80=9D when using it with an HP H241 SAS HBA card. > The driver works fine when all (SAS, spinning rust) drives are behavin= g well, but when some of them are starting to go bad it often goes into spi= n and either hangs the kernel or panics. I=E2=80=99ve been trying to add in= strumentation to it in order to pin-point the problem and have been attempt= ing some workarounds (like clearing cr_complete since without that hack som= etime the driver get many many non-busy repeated requests with the same =E2= =80=9Ctag=E2=80=9D and then It panics with:
(...)
>
> - Any suggestions? (Probably not but I thought I=E2=80=99d ask anyway = :-)
>

Hello Peter,

I have no suggestion but a question. Does the panic happen with
https://reviews.freebsd.org/D25155 applied ? I am u= sing your patch from
this review with a few drives. It's handy and still builds fine on
15-CURRENT.

I think he'll still get panics from that since his panics we= re from bugs in the recovery code, i think, and that patch doesn't real= ly change that code. There may be more diagnostics produced from that code,= so it may be worth trying...

Warner

Cheers

--
Marek Zarychta

--000000000000545d6806191f667e--