Date: Fri, 7 Aug 1998 23:01:24 GMT From: clkao@CirX.ORG To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: bin/7519: finger(1) i18n support broken Message-ID: <199808072301.XAA07463@CirX.ORG>
next in thread | raw e-mail | index | archive | help
>Number: 7519 >Category: bin >Synopsis: finger(1) i18n support broken >Confidential: yes >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Aug 7 08:00:01 PDT 1998 >Last-Modified: >Originator: Chia-liang Kao >Organization: CirX >Release: FreeBSD 2.2.7-STABLE i386 >Environment: FreeBSD genius.cirx.org 2.2.7-STABLE FreeBSD 2.2.7-STABLE #0: Sat Aug 1 14:28:41 GMT 1998 clkao@genius.cirx.org:/usr/local/src-2.2/sys/compile/GENIUS i386 >Description: the function vputc, which is determining if a charater is printable(by isprint) is taking int parameter, while isprint only works properly with unsigned char (or int). I haven't taken a look if vputc should take int or char. also, the following patch kills a warning in -Wall >How-To-Repeat: >Fix: --- lprint.c.orig Fri Aug 7 22:53:46 1998 +++ lprint.c Fri Aug 7 22:59:35 1998 @@ -297,7 +297,7 @@ struct stat sb; register FILE *fp; register int ch, cnt, lastc; - register char *p; + register u_char *p; int fd, nr; (void)snprintf(tbuf, sizeof(tbuf), "%s/%s", directory, file_name); @@ -353,7 +353,7 @@ meta = 1; } else meta = 0; - if (isprint(ch) || !meta && (ch == ' ' || ch == '\t' || ch == '\n')) + if (isprint(ch) || (!meta && (ch == ' ' || ch == '\t' || ch == '\n'))) (void)putchar(ch); else { (void)putchar('^'); >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808072301.XAA07463>