From owner-freebsd-ports Sun Jul 28 8: 0:17 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 550EC37B400 for ; Sun, 28 Jul 2002 08:00:09 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A86643E5E for ; Sun, 28 Jul 2002 08:00:08 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6SF08JU028428 for ; Sun, 28 Jul 2002 08:00:08 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6SF08Ec028427; Sun, 28 Jul 2002 08:00:08 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C5F9D37B405 for ; Sun, 28 Jul 2002 07:55:38 -0700 (PDT) Received: from ooblick.com (max2k-186.his.com [216.194.203.186]) by mx1.FreeBSD.org (Postfix) with ESMTP id B363F43E42 for ; Sun, 28 Jul 2002 07:52:44 -0700 (PDT) (envelope-from arensb@ooblick.com) Received: (from arensb@localhost) by baa.ooblick.com (8.11.6/8.11.6) id g6SEl4R19756; Sun, 28 Jul 2002 10:47:04 -0400 (EDT) (envelope-from arensb) Message-Id: <200207281447.g6SEl4R19756@baa.ooblick.com> Date: Sun, 28 Jul 2002 10:47:04 -0400 (EDT) From: Andrew &urger Reply-To: Andrew &urger To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/41085: palm/coldsync broken under FreeBSD 4.5 and above Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 41085 >Category: ports >Synopsis: palm/coldsync broken under FreeBSD 4.5 and above >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jul 28 08:00:05 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Andrew &urger >Release: FreeBSD 4.4-RELEASE i386 >Organization: >Environment: FreeBSD 4.6 (sorry, I don't have access to a machine that explicitly exhibits the problem). REINPLACE_CMD in ports Makefiles should be 'sed' (not Perl). >Description: I just got the following message: From: Derik van Zuetphen To: arensb+freebsd-ports@ooblick.com Subject: FreeBSD Port: coldsync-2.1.3_3 Hello, I just noticed that your Coldsync Port is broken on FreeBSD 4.6. Error message after make: Extracting for coldsync-2.1.3_3 >> Checksum OK for coldsync-2.1.3.tar.gz. ===> coldsync-2.1.3_3 depends on shared library: intl.2 - found ===> Patching for coldsync-2.1.3_3 ===> Applying FreeBSD patches for coldsync-2.1.3_3 /usr/bin/sed -i.bak -e 's,udi\.(\S+),udi.udi_\1,g;' -e 's,ur\.(\S+),ur.ucr_\1,g;' /usr/ports/palm/coldsync/work/coldsync-2.1.3/configure /usr/ports/palm/coldsync/work/coldsync-2.1.3/libpconn/PConnection_usb.c sed: 1: "s,udi\.(\S+),udi.udi_\1 ...": \1 not defined in the RE *** Error The problem lies in the post-patch target in the Makefile. The relevant lines are: ${REINPLACE_CMD} -e 's,udi\.(\S+),udi.udi_\1,g;' \ -e 's,ur\.(\S+),ur.ucr_\1,g;' \ I've confirmed under FreeBSD 4.4 that if REINPLACE_CMD is 'sed', then this will not work as expected, since by default sed wants "\(" and "\)" instead of "(" and ")", and doesn't understand "\S". This target does work as expected if REINPLACE_CMD is 'perl -p'. >How-To-Repeat: % cd /usr/ports/palm/coldsync % make >Fix: From the original message: To fix: Add a -E after the sed call in Makefile: % diff Makefile Makefile.orig 41c41 < ${REINPLACE_CMD} -E -e 's,udi\.(\S+),udi.udi_\1,g;' \ --- > ${REINPLACE_CMD} -e 's,udi\.(\S+),udi.udi_\1,g;' \ >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message