From owner-freebsd-gecko@freebsd.org Tue Aug 8 04:37:08 2017 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58E9EDC0152 for ; Tue, 8 Aug 2017 04:37:08 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 44F596E570 for ; Tue, 8 Aug 2017 04:37:08 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 44621DC0151; Tue, 8 Aug 2017 04:37:08 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 44157DC0150 for ; Tue, 8 Aug 2017 04:37:08 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 26DC06E56F; Tue, 8 Aug 2017 04:37:08 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 7A61911ED4; Tue, 8 Aug 2017 04:37:07 +0000 (UTC) From: Jan Beich To: Francois Marier Cc: gecko@FreeBSD.org, =?utf-8?Q?Ren=C3=A9?= Ladan Subject: Re: Firefox 56 in FreeBSD: Safe Browsing API key required References: <7a098f0b-2412-5ea5-5378-eb36c68fee2a@mozilla.com> Date: Tue, 08 Aug 2017 06:37:02 +0200 In-Reply-To: <7a098f0b-2412-5ea5-5378-eb36c68fee2a@mozilla.com> (Francois Marier's message of "Mon, 7 Aug 2017 19:38:18 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2017 04:37:08 -0000 Francois Marier writes: > Hi, > > I'm responsible for Safe Browsing in Firefox and I am reaching out to > make sure that FreeBSD is ready for Firefox 56 (to be released on > 2017-09-26). > > In that version, we will be switching to the latest version of the Safe > Browsing API for our malware/phishing protection and that requires a > valid API key from Google. Do you mean "google" or "google4" in about:url-classifier? Both seem to be available in FF55 and FF56. However, "google4" currently fails as "cannot update" or "download error (400)" e.g., $ firefox -new-instance -profile $(mktemp -d) about:url-classifier Safe Browsing server returned a 400 during update: request = https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=<...>&$httpMethod=POST&$req=<...> > > You seem to be passing it as an environment variable: > > https://svnweb.freebsd.org/ports/head/www/firefox/files/patch-env-api-keys?view=markup The patch is just a workaround to avoid having to generate a temporary file. The API key is in another file, see https://svnweb.freebsd.org/ports/head/Mk/bsd.gecko.mk?view=markup#l276 > If you are indeed already including a Google API key in your builds, > then all you need to do is to add the Safe Browsing API to it, see > https://bugzilla.mozilla.org/show_bug.cgi?id=1377987#c0. Does SafeBrowsing require defining MOZILLA_OFFICIAL during build which would also enable Telemetry pings? > > Afterwards, if you send me the project ID (not the API key), I can > liaise with Google to make sure it has the right access and appropriate > quota. Our gecko@ team shares Google API key with chromium@ team. rene@ was the one who originally obtained the key, so maybe he still has the project ID. I can't really help with anything that requires a Google Account as signing up for one doesn't work via Tor.